From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68246: 30.0.50; Add non-TS mode as extra parent of TS modes Date: Fri, 05 Jan 2024 15:26:00 +0200 Message-ID: <83o7dzvrmf.fsf@gnu.org> References: <83edeww73j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31864"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68246@debbugs.gnu.org, monnier@iro.umontreal.ca To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 05 14:27:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLkEN-00080w-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jan 2024 14:27:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLkE7-0002tb-HT; Fri, 05 Jan 2024 08:27:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLkDz-0002nQ-BT for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 08:27:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLkDy-0003OO-DB for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 08:26:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLkE2-0006xM-Jr for bug-gnu-emacs@gnu.org; Fri, 05 Jan 2024 08:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jan 2024 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68246 X-GNU-PR-Package: emacs Original-Received: via spool by 68246-submit@debbugs.gnu.org id=B68246.170446118926670 (code B ref 68246); Fri, 05 Jan 2024 13:27:02 +0000 Original-Received: (at 68246) by debbugs.gnu.org; 5 Jan 2024 13:26:29 +0000 Original-Received: from localhost ([127.0.0.1]:56667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLkDV-0006w6-8Y for submit@debbugs.gnu.org; Fri, 05 Jan 2024 08:26:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLkDS-0006vp-AE for 68246@debbugs.gnu.org; Fri, 05 Jan 2024 08:26:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLkDH-0003Fu-4J; Fri, 05 Jan 2024 08:26:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SLi4+BIHlMRY01n6wP67UNGTF/Aa8Hv1e8Ot6lRYk9M=; b=anp7CVfKC2zriOc3RzFx McN76nUyavQOWcwVMZNrKl1J2Z/yRxOdXMbot3vyNZwZD1kiDXk6KJw+aZipLanu2EUl0UHRsnGx7 6SsCQ0kzUIi/yM35VR8LUWpNbDReNwyboFBmMns0MHPdAW6wDrjDN5ewkPOEtU/exCtd8KsrsnKsE b0kFS4AAilszfWJeQmFcuu+0guOFnAUlvthE5rMZKBBO8QqJidwW9k+PfjDiqUPRpAPRsBvMKh7yx eLox5+R3SXlJTmrYWj2ZWB/hn1qHJlbVbahXx6kE3gxZEBg7+p67n+9xgTJiyEOCz8e5MEa26jGnt WzMxgoR3tpsu7w==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Fri, 5 Jan 2024 11:27:53 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277387 Archived-At: > From: João Távora > Date: Fri, 5 Jan 2024 11:27:53 +0000 > Cc: monnier@iro.umontreal.ca, 68246@debbugs.gnu.org > > base-foo-mode is a natural place for setup that is common > to both foo-mode and foo-ts-mode to exist. There is a > good number of things that are independent of the particular > implementation of parsing (lisp-based vs ts-based). > > Is it too late for the ts-modes to be looked at like that? It doesn't always make sense. Where it does make sense, I think we did it (see python-ts-mode, for example). > It seems our approach to TS modes often/always looks like > 'foo-rewrite-completely-using-ts-while-at-it-mode'. That's right -- but it's justified. The commonality is usually either very thin or almost non-existent. If you think about it, you will understand: where the traditional modes use regexps and syntax-pss, the TS modes use parser-related primitives. How can you find common grounds between these so different bases for implementation? > > It should modify our .dir-locals.el and Eglot's database to > > remove special entries for TS modes > > As Dmitry mentioned: if that is done just like that it will > break Eglot's support of ts modes in any Emacs which doesn't > have Stefan's patch. Then Eglot (or maybe compat.el) will have to provide compatibility shims. But for .dir-locals.el, I still think we should update it. > Also, I know this mail is long enough, but apropos Eglot's > database, it's getting quite large as you may notice. Another, > much more natural way to simplify it would be, if major-modes > started setting eglot-server-program (singular) buffer-locally > variable which takes precedence over eglot-server-programs. Maybe. But that's an unrelated issue.