From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 7728@debbugs.gnu.org
Subject: bug#7728: 24.0.50; GDB backtrace from abort
Date: Tue, 11 Jan 2011 23:14:26 +0200 [thread overview]
Message-ID: <83mxn7i1n1.fsf@gnu.org> (raw)
In-Reply-To: <jwvk4ibkwgv.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: drew.adams@oracle.com, 7728@debbugs.gnu.org
> Date: Tue, 11 Jan 2011 15:55:12 -0500
>
> There's still one thing I don't understand: why do we call
> Fselect_frame? AFAICT, Fset_window_configuration has no reason to
> select a new frame, it all works within the selected-frame.
Probably because of minibuffer-only frames or something.
Perhaps Drew could publish the relevant parts of the window
configuration that was being restored in that case (or any other
similar case).
> > So I see 2 ways to prevent this particular problem:
> > 1) Handle the case of selected_window == Qnil in
> > CURRENT_MODE_LINE_FACE_ID.
>
> But should it always return the mode-line-inactive face here, or should
> it always return the mode-line face?
I don't think it matters much, since if we don't have a window to work
with, we are only guesstimating anyway.
> > 2) Change the code of Fset_window_configuration and Fselect_window,
> > to have some other way of preventing the latter from storing point
> > in the old selected window, without setting selected_window to
> > nil.
>
> That sounds like a better solution. E.g. move the code of
> Fselect_window to another function, add a third argument to it
> specifying whether to swap-out point in selected_window, and make
> Fset_window_configuration call that new internal function.
Yes, something like that.
next prev parent reply other threads:[~2011-01-11 21:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 16:55 bug#7728: 24.0.50; GDB backtrace from abort Drew Adams
2010-12-25 9:38 ` Eli Zaretskii
2010-12-25 10:44 ` Andreas Schwab
2010-12-25 11:12 ` Eli Zaretskii
2010-12-25 20:35 ` Stefan Monnier
2011-01-01 18:02 ` Eli Zaretskii
2011-01-09 21:18 ` Eli Zaretskii
2011-01-10 23:32 ` Drew Adams
2011-01-11 20:55 ` Stefan Monnier
2011-01-11 21:14 ` Eli Zaretskii [this message]
2011-01-11 21:44 ` Drew Adams
2011-01-12 4:11 ` Eli Zaretskii
2011-01-12 4:59 ` Drew Adams
2011-01-12 11:03 ` Eli Zaretskii
2011-01-12 18:36 ` Drew Adams
2011-01-12 19:52 ` Drew Adams
2011-01-12 21:30 ` Drew Adams
2011-01-12 7:54 ` martin rudalics
2011-01-12 15:05 ` Drew Adams
2011-01-12 15:14 ` Stefan Monnier
2011-01-12 15:59 ` martin rudalics
2011-01-12 16:22 ` Eli Zaretskii
2011-01-12 17:42 ` martin rudalics
2011-01-12 17:48 ` Eli Zaretskii
2011-01-12 18:35 ` martin rudalics
2011-01-12 18:36 ` Drew Adams
2011-01-15 2:59 ` Chong Yidong
2011-01-15 20:05 ` martin rudalics
2011-01-13 2:53 ` Stefan Monnier
2011-01-13 7:07 ` Drew Adams
2011-01-13 17:02 ` Stefan Monnier
2011-01-13 17:57 ` Drew Adams
2011-01-13 21:24 ` Stefan Monnier
2011-01-13 22:06 ` Drew Adams
2011-01-14 0:26 ` Eli Zaretskii
2011-01-14 1:19 ` Drew Adams
2011-01-14 2:40 ` Eli Zaretskii
2011-01-14 6:46 ` Drew Adams
2011-01-14 7:09 ` Drew Adams
2011-01-14 20:01 ` Sean Sieger
2011-01-14 21:06 ` Drew Adams
2011-01-14 21:46 ` Sean Sieger
2011-01-14 22:51 ` Eli Zaretskii
2011-01-14 23:56 ` Sean Sieger
2011-01-14 2:25 ` Stefan Monnier
2011-01-14 4:25 ` Drew Adams
2011-01-14 8:26 ` martin rudalics
2011-01-14 8:58 ` Drew Adams
2011-01-14 15:30 ` Stefan Monnier
2011-01-16 20:44 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mxn7i1n1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=7728@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).