unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 15015@debbugs.gnu.org
Subject: bug#15015: Fix some minor races in hosts lacking mkostemp
Date: Sat, 03 Aug 2013 11:38:03 +0300	[thread overview]
Message-ID: <83mwozxj84.fsf@gnu.org> (raw)
In-Reply-To: <51FCB3D5.7070704@cs.ucla.edu>

> Date: Sat, 03 Aug 2013 00:40:05 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>
> 
> Here's a proposed patch to fix some minor races in hosts lacking mkostemp.
> I've tested this on Fedora 17 and Solaris 9.  Eli recently wrote that he
> didn't think it was feasible to close the races on Microsoft platforms,
> so I'm posting this on bug-gnu-emacs first (with a CC: to Eli to give him
> a heads-up).  It looks to me like it may close the races on Microsoft platforms,
> at least if they support O_EXCL, and at any rate I hope it doesn't hurt
> on those platforms.
> 
> Most of this patch consists of code copied automatically from Gnulib.
> The meat of the patch is in src/callproc.c and src/filelock.c.

Thanks.  However, I'm reluctant to use the gnulib mkostemp module,
because it relies on quite a few functions that are redefined in
Emacs, and I have no idea what will this do to the gnulib
implementation.  Also, since we still didn't remove the support for
MS-Windows builds that use nt/configure.bat and the makefile-w32.in
files, the uses of mktemp in the Emacs sources should be left alone
for now, if we go this route.

I thought of a far easier solution: use the same code as sys_mktemp
does, but use 'open' or '_sopen' instead of faccessat.  I think this
will solve the problem much more locally and with much smaller impact.
If you agree, I will work on providing 'mkostemp' for w32.

In any case, we cannot just remove the other alternatives; at least
for the MSDOS build we need to keep the HAVE_MKSTEMP version.





  reply	other threads:[~2013-08-03  8:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  7:40 bug#15015: Fix some minor races in hosts lacking mkostemp Paul Eggert
2013-08-03  8:38 ` Eli Zaretskii [this message]
2013-08-03  9:02   ` Eli Zaretskii
2013-08-03 14:40     ` Paul Eggert
2013-08-03 14:55       ` Eli Zaretskii
2013-08-03 21:26         ` Paul Eggert
2013-08-04 15:44           ` Eli Zaretskii
2013-08-04 17:01             ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mwozxj84.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=15015@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).