unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 18237@debbugs.gnu.org
Subject: bug#18237: Small fix for MSDOS
Date: Sun, 10 Aug 2014 21:02:56 +0300	[thread overview]
Message-ID: <83mwbcjk8f.fsf@gnu.org> (raw)
In-Reply-To: <CAOnWdohJbtv-m6TyCuG9JJF=6iMMcz2L2Syy9d6+SnFaU2xTVw@mail.gmail.com>

> Date: Sun, 10 Aug 2014 17:40:24 +0100
> From: Reuben Thomas <rrt@sc3d.org>
> 
> The following patch helps in the case when a sockets library is installed;
> in my case, ls080b.zip from the DJGPP site:
> 
> === modified file 'src/msdos.c'
> --- src/msdos.c    2014-08-09 16:12:33 +0000
> +++ src/msdos.c    2014-08-09 21:51:56 +0000
> @@ -4016,7 +4017,7 @@
>  #endif
> 
> 
> -#ifndef HAVE_SELECT
> +#ifndef HAVE_SYS_SELECT_H
>  #include "sysselect.h"
> 
>  /* This yields the rest of the current time slice to the task manager.
> 
> 
> The reasoning is that having select doesn't imply having the sys/select.h
> functionality that the following code emulates.
> 
> Does that look OK to install?

You didn't tell enough details, so I don't understand why the change
is needed, and why it is OK not to test HAVE_SELECT at all here.  (I
don't have ls080b.zip installed.)  Please tell what problems did you
see with the original code, and let's take it from there.

Thanks.





  reply	other threads:[~2014-08-10 18:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10 16:40 bug#18237: Small fix for MSDOS Reuben Thomas
2014-08-10 18:02 ` Eli Zaretskii [this message]
2014-08-10 18:19   ` Reuben Thomas
2014-08-10 18:26     ` Eli Zaretskii
2014-08-10 18:42       ` Reuben Thomas
2014-08-10 19:05         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mwbcjk8f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=18237@debbugs.gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).