From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data Date: Sat, 11 Apr 2015 21:35:33 +0300 Message-ID: <83mw2eecne.fsf@gnu.org> References: <6343E9EC-9E23-4D44-9CD1-82C26DB7CDA3@sanityinc.com> <8292DA72-0898-47B2-A1C1-F7D94A52A437@sanityinc.com> <878udysfn2.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1428777653 2613 80.91.229.3 (11 Apr 2015 18:40:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 11 Apr 2015 18:40:53 +0000 (UTC) Cc: steve@sanityinc.com, 20231@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 11 20:40:42 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yh0Kg-0008La-3z for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Apr 2015 20:40:42 +0200 Original-Received: from localhost ([::1]:43557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yh0Kf-0002AE-FP for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Apr 2015 14:40:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yh0GE-0003Ns-Bf for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2015 14:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yh0GA-00049t-Pn for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2015 14:36:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yh0GA-00049e-MZ for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2015 14:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yh0GA-00071G-9L for bug-gnu-emacs@gnu.org; Sat, 11 Apr 2015 14:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Apr 2015 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20231 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20231-submit@debbugs.gnu.org id=B20231.142877733926954 (code B ref 20231); Sat, 11 Apr 2015 18:36:02 +0000 Original-Received: (at 20231) by debbugs.gnu.org; 11 Apr 2015 18:35:39 +0000 Original-Received: from localhost ([127.0.0.1]:53399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yh0Fn-00070g-CJ for submit@debbugs.gnu.org; Sat, 11 Apr 2015 14:35:39 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:52970) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yh0Fk-00070S-Cy for 20231@debbugs.gnu.org; Sat, 11 Apr 2015 14:35:37 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NMN00J00NEOA300@mtaout28.012.net.il> for 20231@debbugs.gnu.org; Sat, 11 Apr 2015 21:34:13 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NMN00HVFNL1OU10@mtaout28.012.net.il>; Sat, 11 Apr 2015 21:34:13 +0300 (IDT) In-reply-to: <878udysfn2.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101435 Archived-At: > From: Ivan Shmakov > Date: Sat, 11 Apr 2015 18:07:13 +0000 > > >>>>> Steve Purcell writes: > > > --- a/lisp/emacs-lisp/package.el > > +++ b/lisp/emacs-lisp/package.el > > @@ -1279,12 +1279,13 @@ defun package--read-archive-file (file) > > (let ((filename (expand-file-name file package-user-dir))) > > (when (file-exists-p filename) > > (with-temp-buffer > > - (insert-file-contents-literally filename) > > - (let ((contents (read (current-buffer)))) > > - (if (> (car contents) package-archive-version) > > - (error "Package archive version %d is higher than %d" > > - (car contents) package-archive-version)) > > - (cdr contents)))))) > > + (let ((coding-system-for-read 'utf-8)) > > + (insert-file-contents filename) > > As insert-file-contents may imply a whole lot of additional > processing beyond decoding UTF-8, I’d rather use an explicit > decode-coding-region here Can you explain why? What additional processing can get in the way?