From: Eli Zaretskii <eliz@gnu.org>
To: Teddy Hogeborn <teddy@recompile.se>
Cc: 20704@debbugs.gnu.org
Subject: bug#20704: info.el bug fix; Interprets Info format wrongly
Date: Tue, 09 Jun 2015 17:29:09 +0300 [thread overview]
Message-ID: <83mw09t0p6.fsf@gnu.org> (raw)
In-Reply-To: <87h9qhf8a3.fsf@tower.recompile.se>
> From: Teddy Hogeborn <teddy@recompile.se>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 20704@debbugs.gnu.org
> Date: Tue, 09 Jun 2015 13:09:08 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > > > + (+ (point-min) (byte-to-position
> > > > + (read (current-buffer))))
> > >
> > > Hmm... this only works if the Info file is encoded in UTF-8. I
> > > guess in the case of Info, 99% of the files are just ASCII and
> > > there's a chance that the vast majority of the rest is (or will be)
> > > UTF-8, so maybe this hack works well in practice.
> >
> > Using byte-to-position would make things worse for Latin-1 and the
> > likes.
>
> No, byte-to-position already checks for that:
>
> ---- src/marker.c, line 302
> /* If this buffer has as many characters as bytes,
> each character must be one byte.
> This takes care of the case where enable-multibyte-characters is nil. */
> if (best_above == best_above_byte)
> return bytepos;
> ----
I think you are misreading the code: the above snippet is for unibyte
buffers, whereas a Latin-1 encoded Info file will be read into a
multibyte buffer (and decoded into the internal Emacs representation
of characters during the read). So this optimization is not going to
work in that case.
IOW, what matters for byte-to-position is the encoding used in
representing characters in Emacs buffers, not the one used externally
by the Info file on disk.
> Therefore, an Info file in Latin-1 should work just fine.
>
> > But it shouldn't be hard to add a simple test of
> > buffer-file-coding-system: if it states fixed-size encoding, like any
> > of the 8-bit encodings, or UTF-16,
> > the conversion to character position is trivial.
>
> I think you mean UTF-32 instead of UTF-16, since UTF-16 is variable-
> length.
UTF-16 is fixed length for characters in the BMP.
next prev parent reply other threads:[~2015-06-09 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 14:54 bug#20704: info.el bug fix; Interprets Info format wrongly Teddy Hogeborn
2015-06-01 14:01 ` Stefan Monnier
2015-06-01 15:12 ` Eli Zaretskii
2015-06-09 11:09 ` Teddy Hogeborn
2015-06-09 14:29 ` Eli Zaretskii [this message]
2015-06-09 16:01 ` Stefan Monnier
2015-06-10 17:50 ` Stefan Monnier
2015-06-10 18:21 ` Eli Zaretskii
2015-06-11 3:02 ` Stefan Monnier
2015-06-11 13:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mw09t0p6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20704@debbugs.gnu.org \
--cc=teddy@recompile.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).