From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22789: 25.1.50; In last master build https connections stop working Date: Mon, 07 Mar 2016 18:07:54 +0200 Message-ID: <83mvqauv8l.fsf@gnu.org> References: <864mcyo14y.fsf@Lenovo-PC.i-did-not-set--mail-host-address--so-tickle-me> <86oab1vjm9.fsf@realize.ch> <86d1rhpvcq.fsf@realize.ch> <834mctbitq.fsf@gnu.org> <868u25p3m2.fsf@realize.ch> <83io18ahya.fsf@gnu.org> <86y4a3on6f.fsf@realize.ch> <87oaazg7fv.fsf@gnus.org> <86twkro0vr.fsf@realize.ch> <83d1rf8ifj.fsf@gnu.org> <86povfnm9r.fsf@realize.ch> <8337sa9865.fsf@gnu.org> <86bn6ynrbw.fsf@realize.ch> <83vb566v5b.fsf@gnu.org> <83d1razkmq.fsf@gnu.org> <86egbqkwsb.fsf@realize.ch> <86a8mekjrb.fsf@realize.ch> <83k2lhxria.fsf@gnu.org> <86egbo232a.fsf@realize.ch> <83si04wx18.fsf@gnu.org> <8660wz1azm.fsf@realize.ch> <861t7n1970.fsf@realize.ch> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1457366909 28923 80.91.229.3 (7 Mar 2016 16:08:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2016 16:08:29 +0000 (UTC) Cc: larsi@gnus.org, j_l_domenech@yahoo.com, 22789@debbugs.gnu.org To: Alain Schneble Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 07 17:08:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1acxhf-0006n7-QG for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2016 17:08:16 +0100 Original-Received: from localhost ([::1]:56745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acxhe-00055n-Rj for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2016 11:08:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acxhW-00054c-2Z for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:08:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acxhS-0003SV-87 for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:08:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acxhS-0003SE-4z for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1acxhR-00057T-V6 for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Mar 2016 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22789-submit@debbugs.gnu.org id=B22789.145736688019672 (code B ref 22789); Mon, 07 Mar 2016 16:08:01 +0000 Original-Received: (at 22789) by debbugs.gnu.org; 7 Mar 2016 16:08:00 +0000 Original-Received: from localhost ([127.0.0.1]:38237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acxhP-00057D-RE for submit@debbugs.gnu.org; Mon, 07 Mar 2016 11:08:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58412) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acxhO-000572-Ex for 22789@debbugs.gnu.org; Mon, 07 Mar 2016 11:07:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acxhF-0003MX-Fk for 22789@debbugs.gnu.org; Mon, 07 Mar 2016 11:07:53 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acxhF-0003MT-Bw; Mon, 07 Mar 2016 11:07:49 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1acxhE-0001ou-H1; Mon, 07 Mar 2016 11:07:48 -0500 In-reply-to: <861t7n1970.fsf@realize.ch> (message from Alain Schneble on Mon, 7 Mar 2016 00:24:35 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114535 Archived-At: > From: Alain Schneble > CC: , , <22789@debbugs.gnu.org> > Date: Mon, 7 Mar 2016 00:24:35 +0100 > > > I'll send a patch for further discussions shortly. > > And here it is. The fix is quite simple. It ensures that sys_write > exits before touching the socket if it is not connected yet. > Unfortunately I didn't find any documentation on winsock ioctlsocket > that would prove that this is indeed required. But it seems not wrong > to me anyway. (I'll try to search the wisock documentation tomorrow to > find some hints that lead in this direction, or maybe you know?) I think this change should be installed regardless, as it fixes an oversight. However, I think it needs to be augmented, because the fact that FILE_CONNECT flag is set doesn't necessarily mean the connection is in progress: it could have failed already. We need to look at the status as well. The possible states of the FILE_CONNECT flag and the cp->status values are: flag status description ---------------------------------------------------------------------------- ON STATUS_READ_READY reader thread is about to try connect ON STATUS_READ_FAILED reader thread waits in _sys_wait_connect ON STATUS_READ_SUCCEEDED reader thread successfully connected ON STATUS_CONNECT_FAILED reader thread failed to connect OFF STATUS_READ_ACKNOWLEDGED sys_select acknowledged successful connect OFF STATUS_READ_READY reader thread is about to read OFF STATUS_READ_IN_PROGRESS reader thread waits in _sys_read_ahead OFF STATUS_READ_SUCCEEDED reader thread succeeded in reading OFF STATUS_READ_FAILED reader thread failed to read So we should only return EWOULDBLOCK when FILE_CONNECT is set _and_ the status is not STATUS_CONNECT_FAILED. If FILE_CONNECT is set, but the status is STATUS_CONNECT_FAILED, we should instead return the value computed from cp->errcode (if it is non-zero). There's an example of that in sys_read. Other than that, what specific problem does your change try or is known to solve? IOW, what didn't work before the change, and works after it? Thanks.