From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 23640@debbugs.gnu.org
Subject: bug#23640: 25.1.50; Getting rid of compiler warnings
Date: Sat, 28 May 2016 21:57:29 +0300 [thread overview]
Message-ID: <83mvnaxb6u.fsf@gnu.org> (raw)
In-Reply-To: <ff882ff4-e092-afe2-3a71-e22bce3c114d@cornell.edu> (message from Ken Brown on Sat, 28 May 2016 14:40:36 -0400)
> From: Ken Brown <kbrown@cornell.edu>
> Date: Sat, 28 May 2016 14:40:36 -0400
>
> Building master on Cygwin with gcc-5.3.0 yields many "control reaches
> end of non-void function" warnings. What's the best way to get rid of
> these? Should I add return statements that will never be reached, like
> this?
>
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -263,6 +263,8 @@ See also `frame-live-p'. */)
> return Qns;
> default:
> emacs_abort ();
> + /* Pacify compiler. */
> + return Qnil;
> }
> }
emacs_abort is declared with _Noreturn, so how come GCC doesn't shut
up about "unreachable" code?
FWIW, I'm building master with GCC 5.3.0, and don't see these
warnings.
next prev parent reply other threads:[~2016-05-28 18:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 18:40 bug#23640: 25.1.50; Getting rid of compiler warnings Ken Brown
2016-05-28 18:57 ` Eli Zaretskii [this message]
2016-05-28 21:47 ` Ken Brown
2016-05-29 22:43 ` Ken Brown
2016-05-30 11:39 ` Ken Brown
2016-05-30 14:41 ` Ken Brown
2016-05-30 16:20 ` Ken Brown
2016-05-30 23:29 ` Paul Eggert
2016-05-31 0:11 ` Ken Brown
2016-05-31 8:03 ` Andy Moreton
2016-05-31 22:22 ` Richard Stallman
2016-05-31 0:15 ` Paul Eggert
2016-06-01 8:35 ` Paul Eggert
2016-06-01 20:37 ` Richard Stallman
2016-06-01 21:10 ` Paul Eggert
2016-06-02 12:05 ` Andy Moreton
2016-06-03 3:35 ` Richard Stallman
2016-06-06 14:45 ` Paul Eggert
2016-06-07 6:19 ` Richard Stallman
2016-06-07 7:15 ` Paul Eggert
2016-06-08 4:00 ` Richard Stallman
2016-06-08 7:18 ` Paul Eggert
2016-06-08 17:06 ` Richard Stallman
2016-06-01 8:55 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvnaxb6u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23640@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).