From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24923: 25.1; Lisp watchpoints Date: Sun, 20 Nov 2016 17:58:17 +0200 Message-ID: <83mvgu9m92.fsf@gnu.org> References: <87vavun235.fsf@users.sourceforge.net> <83eg2ie3lp.fsf@gnu.org> <87pom1mi3q.fsf@users.sourceforge.net> <83r36hcghy.fsf@gnu.org> <87fumwmc7q.fsf@users.sourceforge.net> <83fumvcs99.fsf@gnu.org> <874m32lx1e.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1479657557 9061 195.159.176.226 (20 Nov 2016 15:59:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 Nov 2016 15:59:17 +0000 (UTC) Cc: 24923@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 20 16:59:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8UWN-0001Eu-Tq for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Nov 2016 16:59:12 +0100 Original-Received: from localhost ([::1]:45337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8UWR-0003kp-8g for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Nov 2016 10:59:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8UWI-0003jc-JF for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2016 10:59:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8UWE-0007xn-KQ for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2016 10:59:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8UWE-0007xh-Ga for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2016 10:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c8UWE-0006SH-63 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2016 10:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2016 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24923-submit@debbugs.gnu.org id=B24923.147965750024742 (code B ref 24923); Sun, 20 Nov 2016 15:59:02 +0000 Original-Received: (at 24923) by debbugs.gnu.org; 20 Nov 2016 15:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:36264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8UVY-0006Qy-CA for submit@debbugs.gnu.org; Sun, 20 Nov 2016 10:58:20 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8UVW-0006Qf-4Y for 24923@debbugs.gnu.org; Sun, 20 Nov 2016 10:58:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8UVM-0007og-R4 for 24923@debbugs.gnu.org; Sun, 20 Nov 2016 10:58:12 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8UVM-0007oc-O7; Sun, 20 Nov 2016 10:58:08 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1664 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c8UVL-00063d-E2; Sun, 20 Nov 2016 10:58:08 -0500 In-reply-to: <874m32lx1e.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125901 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 24923@debbugs.gnu.org > Date: Sat, 19 Nov 2016 21:12:13 -0500 > > Eli Zaretskii writes: > > > > Our coding conventions put the logical operators at the beginning of a > > line, not at EOL. > > Fixed this, and added documentation. Also, watcher functions are now > listed in describe-variable output. Thanks. > Does it make sense to mention the use of the `watchers' symbol property > in the manual? Since I've added a `get-variable-watchers' it's now > possible to ignore the symbol property as an implementation detail. I think the property can indeed be left undocumented. > @@ -1233,13 +1233,14 @@ DEFUN ("set", Fset, Sset, 2, 2, 0, > If buffer/frame-locality is an issue, WHERE specifies which context to use. > (nil stands for the current buffer/frame). > > - If BINDFLAG is false, then if this symbol is supposed to become > - local in every buffer where it is set, then we make it local. > - If BINDFLAG is true, we don't do that. */ > + If BINDFLAG is SET_INTERNAL_SET, then if this symbol is supposed to > + become local in every buffer where it is set, then we make it > + local. If BINDFLAG is SET_INTERNAL_BIND or SET_INTERNAL_UNBIND, we > + don't do that. */ What are those SET_INTERNAL_* values? They are numbers, right? Then they should be described as such in the doc string. > +(defun cancel-debug-on-variable-change (&optional variable) > + "Undo effect of \\[debug-on-entry] on VARIABLE. ^^^^^^^^^^^^^^^^^^ Copy/paste error. I will comment on the documentation in a separate message.