From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25440: 25.1.90; Incorrect documentation for sql-product-alist in sql.el Date: Sat, 14 Jan 2017 10:41:43 +0200 Message-ID: <83mveuav94.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1484383350 3712 195.159.176.226 (14 Jan 2017 08:42:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2017 08:42:30 +0000 (UTC) Cc: 25440-done@debbugs.gnu.org To: Alex Hutcheson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 14 09:42:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSJud-0007gF-06 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2017 09:42:11 +0100 Original-Received: from localhost ([::1]:47002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSJuh-00033l-N3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2017 03:42:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSJuY-0002xV-2o for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2017 03:42:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSJuU-0004t6-U1 for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2017 03:42:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cSJuU-0004sz-Qg for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2017 03:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cSJuU-0003Dx-H2 for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2017 03:42:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2017 08:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 25440@debbugs.gnu.org, eliz@gnu.org, alexhutcheson@google.com Original-Received: via spool by 25440-done@debbugs.gnu.org id=D25440.148438330412365 (code D ref 25440); Sat, 14 Jan 2017 08:42:02 +0000 Original-Received: (at 25440-done) by debbugs.gnu.org; 14 Jan 2017 08:41:44 +0000 Original-Received: from localhost ([127.0.0.1]:53336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSJuB-0003DN-VK for submit@debbugs.gnu.org; Sat, 14 Jan 2017 03:41:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSJuA-0003DA-68 for 25440-done@debbugs.gnu.org; Sat, 14 Jan 2017 03:41:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSJu1-0004mf-Qb for 25440-done@debbugs.gnu.org; Sat, 14 Jan 2017 03:41:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSJu1-0004mb-N1; Sat, 14 Jan 2017 03:41:33 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4690 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cSJu0-0002N2-Uv; Sat, 14 Jan 2017 03:41:33 -0500 In-reply-to: (message from Alex Hutcheson on Fri, 13 Jan 2017 12:01:59 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128112 Archived-At: > From: Alex Hutcheson > Date: Fri, 13 Jan 2017 12:01:59 -0500 > > The documentation for the variable 'sql-product-alist' incorrectly > describes the appropriate value for the :sqli-comint-func feature. > The documentation specifies: > > :sqli-comint-func name of a function which accepts no > > parameters that will use the values of ... > > However, the function actually needs to have two parameters: 'product' > and 'options'. See the following two examples in sql.el to confirm: > http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el#n159 > http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el#n4337 > > The doc string for :sqli-comint-func (here: > http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el#n554) > needs to be changed to reflect this. Thanks, fixed for Emacs 25.2.