From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 26597@debbugs.gnu.org
Subject: bug#26597: 25.1; Compilation error on master with --enable-check-lisp-object-type
Date: Sat, 22 Apr 2017 10:42:47 +0300 [thread overview]
Message-ID: <83mvb8riq0.fsf@gnu.org> (raw)
In-Reply-To: <m2shl134rd.fsf@gmail.com> (message from Philipp Stephani on Fri, 21 Apr 2017 22:05:58 +0200)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 21 Apr 2017 22:05:58 +0200
>
> nsterm.m:6969:8: error: member reference base type 'enum z_group' is not a structure or union
> if (!NILP (FRAME_Z_GROUP (f)))
> ^~~~~~~~~~~~~~~~~~~~~~~~
It should compare against z_group_none instead.
> (Tangentially, is there any reason not to define Lisp_Object as struct
> unconditionally, to avoid such coding errors?)
Yes, it produces slower code.
next prev parent reply other threads:[~2017-04-22 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 20:05 bug#26597: 25.1; Compilation error on master with --enable-check-lisp-object-type Philipp Stephani
2017-04-22 7:42 ` Eli Zaretskii [this message]
2017-04-22 11:57 ` Philipp Stephani
2017-04-22 13:35 ` Andreas Schwab
2017-05-01 11:26 ` Philipp Stephani
2017-04-22 13:36 ` Eli Zaretskii
2017-05-01 12:20 ` Stefan Monnier
2017-05-01 14:33 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvb8riq0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26597@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).