From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26892: 25.2; whitespace-mode does not turn off correctly Date: Fri, 19 May 2017 15:27:52 +0300 Message-ID: <83mva92fqv.fsf@gnu.org> References: <837f1ma96f.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1495196952 18565 195.159.176.226 (19 May 2017 12:29:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 May 2017 12:29:12 +0000 (UTC) Cc: 26892-done@debbugs.gnu.org To: Nick Helm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 19 14:29:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBh1m-0004iZ-Su for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 May 2017 14:29:06 +0200 Original-Received: from localhost ([::1]:58536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBh1s-0003wt-8q for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 May 2017 08:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBh1l-0003wo-EY for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 08:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBh1i-0006x1-9I for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 08:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBh1i-0006wh-5z for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 08:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dBh1h-0000Jt-U7 for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 08:29:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2017 12:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 26892@debbugs.gnu.org, eliz@gnu.org, nick@tenpoint.co.nz Original-Received: via spool by 26892-done@debbugs.gnu.org id=D26892.14951968921168 (code D ref 26892); Fri, 19 May 2017 12:29:01 +0000 Original-Received: (at 26892-done) by debbugs.gnu.org; 19 May 2017 12:28:12 +0000 Original-Received: from localhost ([127.0.0.1]:54519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBh0u-0000Im-73 for submit@debbugs.gnu.org; Fri, 19 May 2017 08:28:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBh0t-0000Ia-Bi for 26892-done@debbugs.gnu.org; Fri, 19 May 2017 08:28:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBh0k-0006LT-TN for 26892-done@debbugs.gnu.org; Fri, 19 May 2017 08:28:06 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBh0k-0006LB-QU; Fri, 19 May 2017 08:28:02 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3564 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBh0k-00074r-52; Fri, 19 May 2017 08:28:02 -0400 In-reply-to: (message from Nick Helm on Mon, 15 May 2017 12:26:14 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132637 Archived-At: > From: Nick Helm > CC: Eli Zaretskii > Date: Mon, 15 May 2017 12:26:14 +1200 > > I've written a new test and confirmed it catches this problem. I also > tweaked the original patch to handle another instance of the same bug. > > Patches for whitespace.el and whitespace-tests.el are attached. Thanks, pushed. A couple of notes, for the future: . The test at first failed for me, and needed some tweaking, because whitespace-mode refuses to turn on in batch mode. I guess you ran the tests in interactive mode? You should run tests in batch. . The patch was not applicable without manual editing, because it used file names like whitespace-a.el, which don't exist. Please in the future submit patches produced against the correct file names, preferably with "git diff" or somesuch. . Please include with the patch a ChangeLog-style commit log message (see CONTRIBUTE for details). . Finally, this contribution exhausts the amount of changes we can accept from you without legal paperwork, so I encourage you to start the paperwork rolling, for us to be able to accept your future contributions. (I can send you the forms off-list if you want.) Thanks again for working on this.