unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Saulius Menkevičius" <saulius.menkevicius@gmail.com>
Cc: 27527@debbugs.gnu.org
Subject: bug#27527: 25.2; start-process crash on Windows with 64bit .NET executable
Date: Thu, 29 Jun 2017 17:24:53 +0300	[thread overview]
Message-ID: <83mv8qrhvu.fsf@gnu.org> (raw)
In-Reply-To: <C02702DA-F4D7-4121-A979-6481E9E5A03C@gmail.com> (message from Saulius Menkevičius on Thu, 29 Jun 2017 12:41:55 +0300)

> From: Saulius Menkevičius <saulius.menkevicius@gmail.com>
> Date: Thu, 29 Jun 2017 12:41:55 +0300
> 
> The issue was encountered when debugging a problem with omnisharp-emacs
> package where starting a server process (written for and running in a  .NET/CLR VM)
> crashes emacs with a segfault.
> 
> Recompiling with -g -O0 has revealed a problem in implementation of
> w32_executable_type in src/w32proc.c where the code is attempting to list
> DLL imports in a binary but the import table points to NULL. This code works for
> .NET binaries compiled for x86 so the problem is specific to 64 bit Windows / .NET DLLs.
> 
> The callstack of a crash is below and I have a patch attached that fixes the problem. 
> The patch applies cleanly to both master and emacs-25 branches.

Thanks.

Can you send the diffs generated with the -b switch?  I think all you
did was to condition the use of the import directory on its being
non-NULL, but it's hard to tell judging just by the diffs you posted.





  reply	other threads:[~2017-06-29 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29  9:41 bug#27527: 25.2; start-process crash on Windows with 64bit .NET executable Saulius Menkevičius
2017-06-29 14:24 ` Eli Zaretskii [this message]
2017-06-29 16:10   ` Saulius Menkevičius
2017-07-09 18:19     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mv8qrhvu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27527@debbugs.gnu.org \
    --cc=saulius.menkevicius@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).