From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22689: [PATCH] Add logcount Date: Sat, 30 Sep 2017 14:42:51 +0300 Message-ID: <83mv5c4dl0.fsf@gnu.org> References: <87h9h9pnof.fsf@udel.edu> <20170929174134.e6uxcr63dtyvd6f4@logos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506771858 16721 195.159.176.226 (30 Sep 2017 11:44:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 30 Sep 2017 11:44:18 +0000 (UTC) Cc: 22689@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 30 13:44:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyGBh-0003MS-VR for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Sep 2017 13:44:06 +0200 Original-Received: from localhost ([::1]:38926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyGBp-0005ak-8g for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Sep 2017 07:44:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyGBh-0005aQ-A3 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 07:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyGBe-0004Ff-8u for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 07:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyGBe-0004FV-5r for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 07:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyGBe-0000nY-0G for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2017 07:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Sep 2017 11:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22689-submit@debbugs.gnu.org id=B22689.15067717882975 (code B ref 22689); Sat, 30 Sep 2017 11:44:01 +0000 Original-Received: (at 22689) by debbugs.gnu.org; 30 Sep 2017 11:43:08 +0000 Original-Received: from localhost ([127.0.0.1]:40074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyGAm-0000lv-By for submit@debbugs.gnu.org; Sat, 30 Sep 2017 07:43:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyGAk-0000lV-JC for 22689@debbugs.gnu.org; Sat, 30 Sep 2017 07:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyGAc-0003Zz-68 for 22689@debbugs.gnu.org; Sat, 30 Sep 2017 07:43:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyGAc-0003Zu-2P; Sat, 30 Sep 2017 07:42:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3184 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dyGAa-0008NJ-9G; Sat, 30 Sep 2017 07:42:57 -0400 In-reply-to: <20170929174134.e6uxcr63dtyvd6f4@logos.localdomain> (message from Mark Oteiza on Fri, 29 Sep 2017 13:41:34 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137672 Archived-At: > Date: Fri, 29 Sep 2017 13:41:34 -0400 > From: Mark Oteiza > > I made an attempt implementing this: Thanks. I'm not an expert on these ops, but otherwise the code looks OK to me, modulo the minor comments below. This will eventually need a NEWS entry and some docs in the ELisp manual. > +#if defined (__POPCNT__) && defined (__GNUC__) && (__GNUC__> 4 || (__GNUC__== 4 && __GNUC_MINOR__> 1)) > +#define HAVE_BUILTIN_POPCOUNTLL > +#endif Where does __POPCNT__ definition come from? I don't see it in my GCC's "gcc -dM" output. As for the rest of the condition, I think you should use GNUC_PREREQ, like this: #if GNUC_PREREQ (4, 1, 0) > +static uint64_t > +bitcount64 (uint64_t b) > +{ > + b -= (b >> 1) & 0x5555555555555555; > + b = (b & 0x3333333333333333) + ((b >> 2) & 0x3333333333333333); > + b = (b + (b >> 4)) & 0x0f0f0f0f0f0f0f0f; > + return (b * 0x0101010101010101) >> 56; Shouldn't these constants have a ULL suffix, to make sure they are not truncated to a 32-bit int? > +#else /* HAVE_BUILTIN_POPCOUNTLL */ > + if (XINT (value) <= UINT_MAX) > + XSETINT (res, bitcount32 (XUINT (value))); > + else if (XINT (value) <= ULONG_MAX) > + XSETINT (res, bitcount64 (XUINT (value))); The comparisons against Uxxx_MAX seem to assume that VALUE is unsigned, but that's not guaranteed, right?