unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Davor Rotim <rotim.davor@gmail.com>, Mark Oteiza <mvoteiza@udel.edu>
Cc: 28809@debbugs.gnu.org
Subject: bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’
Date: Fri, 13 Oct 2017 17:33:51 +0300	[thread overview]
Message-ID: <83mv4vjewg.fsf@gnu.org> (raw)
In-Reply-To: <CAMWA6ANOjYph97sU=CBOXCJDmVsSq19pXOGiemjhX5AoXfBU8A@mail.gmail.com> (message from Davor Rotim on Fri, 13 Oct 2017 15:33:24 +0200)

> From: Davor Rotim <rotim.davor@gmail.com>
> Date: Fri, 13 Oct 2017 15:33:24 +0200
> 
> Started with emacs -Q, opened a dired buffer, navigated to an image and pressed C-t .
> on it (image-dired-display-thumb) to generate a thumbnail. That leaves me with only an error message:
> 
> Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor" 1505334534.0059688)

Mark, could you please look at this?  You changed the code to use
floor instead of rounding via format "%.0f", but floor returns an
Emacs integer which can overflow on 32-bit hosts for large time
values, as happens here.  I think we should use ffloor instead, and if
that produces a decimal point, eliminate it with "%.0f" format.

TIA





  reply	other threads:[~2017-10-13 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 13:33 bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’ Davor Rotim
2017-10-13 14:33 ` Eli Zaretskii [this message]
2017-10-14 21:24   ` Mark Oteiza
2017-10-16 16:28     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mv4vjewg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28809@debbugs.gnu.org \
    --cc=mvoteiza@udel.edu \
    --cc=rotim.davor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).