From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 Date: Fri, 10 Nov 2017 15:06:49 +0200 Message-ID: <83mv3up9jq.fsf@gnu.org> References: <83lgjfqsjt.fsf@gnu.org> <87bmkal31b.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1510319291 27840 195.159.176.226 (10 Nov 2017 13:08:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Nov 2017 13:08:11 +0000 (UTC) Cc: shuguang@gmail.com, 29225@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 10 14:08:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD92U-00071l-86 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 14:08:06 +0100 Original-Received: from localhost ([::1]:41653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD92b-0000jQ-Er for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 08:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD92T-0000hr-Di for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 08:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eD92Q-00026N-5b for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 08:08:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eD92Q-00026A-1v for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 08:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eD92P-0000wg-Sf for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 08:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2017 13:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29225-submit@debbugs.gnu.org id=B29225.15103192313570 (code B ref 29225); Fri, 10 Nov 2017 13:08:01 +0000 Original-Received: (at 29225) by debbugs.gnu.org; 10 Nov 2017 13:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:33319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD91b-0000vW-Kp for submit@debbugs.gnu.org; Fri, 10 Nov 2017 08:07:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD91Z-0000vJ-RW for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 08:07:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eD91P-0000Ko-7Y for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 08:07:04 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD91P-0000Kj-3l; Fri, 10 Nov 2017 08:06:59 -0500 Original-Received: from [176.228.60.248] (port=3897 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eD91N-0000sj-0F; Fri, 10 Nov 2017 08:06:58 -0500 In-reply-to: <87bmkal31b.fsf@gmx.de> (message from Michael Albinus on Fri, 10 Nov 2017 13:41:04 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139731 Archived-At: > From: Michael Albinus > Cc: Shuguang Sun , 29225@debbugs.gnu.org > Date: Fri, 10 Nov 2017 13:41:04 +0100 > > "Value is t if setting of ACL was successful, nil otherwise." > > The error message "Converting ACL" "Invalid argument" comes from > Ffile_acl of fileio.c. It *raises* an error instead of silently > returning Qnil, as advertised by the docstring. A similar wrong > behaviour I've found in `tramp-smb-handle-set-file-acl'. > > I would convert both functions to return nil instead of raising an > error, in the emacs-26 branch. Any objection? I think it should return nil when acl_errno_valid returns false, and otherwise signal an error. It currently calls acl_errno_valid in one of the two places where error could happen, but not in the other. And the doc string should be amended to say that. WDYT?