From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: shuguang@gmail.com, 29225@debbugs.gnu.org
Subject: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7
Date: Fri, 10 Nov 2017 15:06:49 +0200 [thread overview]
Message-ID: <83mv3up9jq.fsf@gnu.org> (raw)
In-Reply-To: <87bmkal31b.fsf@gmx.de> (message from Michael Albinus on Fri, 10 Nov 2017 13:41:04 +0100)
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Shuguang Sun <shuguang@gmail.com>, 29225@debbugs.gnu.org
> Date: Fri, 10 Nov 2017 13:41:04 +0100
>
> "Value is t if setting of ACL was successful, nil otherwise."
>
> The error message "Converting ACL" "Invalid argument" comes from
> Ffile_acl of fileio.c. It *raises* an error instead of silently
> returning Qnil, as advertised by the docstring. A similar wrong
> behaviour I've found in `tramp-smb-handle-set-file-acl'.
>
> I would convert both functions to return nil instead of raising an
> error, in the emacs-26 branch. Any objection?
I think it should return nil when acl_errno_valid returns false, and
otherwise signal an error. It currently calls acl_errno_valid in one
of the two places where error could happen, but not in the other. And
the doc string should be amended to say that. WDYT?
next prev parent reply other threads:[~2017-11-10 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 8:24 bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 Shuguang Sun
2017-11-09 17:18 ` Eli Zaretskii
2017-11-10 12:41 ` Michael Albinus
2017-11-10 13:06 ` Eli Zaretskii [this message]
2017-11-10 14:39 ` Michael Albinus
2017-11-10 15:13 ` Eli Zaretskii
2017-11-12 13:21 ` Michael Albinus
2018-01-17 10:05 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mv3up9jq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29225@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=shuguang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).