From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29349: [Patch] Bug 29349: read_key_sequence is only partially recursive. This is a bug. Date: Sun, 19 Nov 2017 20:02:23 +0200 Message-ID: <83mv3idu4w.fsf@gnu.org> References: <20171118093843.GA3819@ACM> <20171119123456.GA4576@ACM> <20171119155908.GB4576@ACM> <83tvxqdwyy.fsf@gnu.org> <20171119174521.GB9922@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511114595 24063 195.159.176.226 (19 Nov 2017 18:03:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2017 18:03:15 +0000 (UTC) Cc: 29349@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 19 19:03:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGTvv-0005gk-IH for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 19:03:07 +0100 Original-Received: from localhost ([::1]:53931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGTw1-0000hf-0N for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Nov 2017 13:03:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGTvt-0000gD-70 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 13:03:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGTvq-0005J9-31 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 13:03:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39216) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGTvp-0005In-VJ for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 13:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGTvp-0006TU-Jg for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2017 13:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29349-submit@debbugs.gnu.org id=B29349.151111456824869 (code B ref 29349); Sun, 19 Nov 2017 18:03:01 +0000 Original-Received: (at 29349) by debbugs.gnu.org; 19 Nov 2017 18:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:47897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGTvb-0006T3-QU for submit@debbugs.gnu.org; Sun, 19 Nov 2017 13:02:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGTva-0006Sq-2A for 29349@debbugs.gnu.org; Sun, 19 Nov 2017 13:02:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGTvR-00051F-Vw for 29349@debbugs.gnu.org; Sun, 19 Nov 2017 13:02:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGTvR-000516-SK; Sun, 19 Nov 2017 13:02:37 -0500 Original-Received: from [176.228.60.248] (port=2149 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eGTvQ-0007qM-RQ; Sun, 19 Nov 2017 13:02:37 -0500 In-reply-to: <20171119174521.GB9922@ACM> (message from Alan Mackenzie on Sun, 19 Nov 2017 17:45:22 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140109 Archived-At: > Date: Sun, 19 Nov 2017 17:45:22 +0000 > Cc: 29349@debbugs.gnu.org > From: Alan Mackenzie > > In the emacs-26 branch, in a Linux tty with GPM configured and working, > type: > > C-h c C-mouse-3 mouse-1 mouse-1 > > , without moving the mouse. This will end up clicking on > "emacs-tutorial". The message printed in the message area is then: > > (translated from > ) at that spot runs the command > help-with-tutorial > > . In the "translated from ", the first event, > C-mouse-3 has been overwritten by mouse-1. This mouse-1 is a mouse-click > from the menu processing. `describe-key-briefly' can then do nothing > other than printing a spurious "translated from" message. > > With the patch applied, the C-down-mouse-3 survives in the raw key > buffer, enabling `describe-key-briefly' to do the Right Thing. It does > this by collecting the menu processing's mouse events in a separate > buffer, then copying that buffer to the main one afterwards. OK, but then (a) please install the patch on master, not on the release branch, and (b) why do we need the followup patch -- with the mouse-1 events injected into the sequence the "translation" looks correct and even educational. Thanks.