From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30056: 25.3; battery-mode-line-string missing leading space Date: Thu, 11 Jan 2018 17:57:30 +0200 Message-ID: <83mv1k4cd1.fsf@gnu.org> References: <83fu7d68bf.fsf@gnu.org> <834lnt5ybx.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1515686189 4993 195.159.176.226 (11 Jan 2018 15:56:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Jan 2018 15:56:29 +0000 (UTC) Cc: 30056@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 11 16:56:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZfD8-0008Vh-Va for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jan 2018 16:56:11 +0100 Original-Received: from localhost ([::1]:52286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZfF7-0003jT-1z for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Jan 2018 10:58:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZfF0-0003it-RI for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2018 10:58:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZfEw-000231-0P for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2018 10:58:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44463) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZfEv-00022g-Tm for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2018 10:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eZfEv-0001MU-NS for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2018 10:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2018 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30056 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30056-submit@debbugs.gnu.org id=B30056.15156862675213 (code B ref 30056); Thu, 11 Jan 2018 15:58:01 +0000 Original-Received: (at 30056) by debbugs.gnu.org; 11 Jan 2018 15:57:47 +0000 Original-Received: from localhost ([127.0.0.1]:52360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZfEg-0001M1-Mg for submit@debbugs.gnu.org; Thu, 11 Jan 2018 10:57:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZfEe-0001Lp-RN for 30056@debbugs.gnu.org; Thu, 11 Jan 2018 10:57:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZfEU-0001K1-IN for 30056@debbugs.gnu.org; Thu, 11 Jan 2018 10:57:39 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZfEU-0001Jj-Ev; Thu, 11 Jan 2018 10:57:34 -0500 Original-Received: from [176.228.60.248] (port=3093 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eZfET-0003EB-D9; Thu, 11 Jan 2018 10:57:33 -0500 In-reply-to: (message from Allen Li on Wed, 10 Jan 2018 15:26:42 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142034 Archived-At: > From: Allen Li > Date: Wed, 10 Jan 2018 15:26:42 -0800 > Cc: Glenn Morris , 30056@debbugs.gnu.org > > >> See also https://debbugs.gnu.org/18164 > > > > We don't do this consistently in the modes which use > > global-mode-string: some of them leave a blank at the beginning, > > others (the majority, AFACT) don't. There's not much space on the > > mode line, so I'm not sure which way is better. > > The standard for minor mode strings is to include a leading space, right? That's just it: I'm not sure. > In any case, Emacs packages should probably be consistent, and > currently display-battery-mode and display-time-mode are inconsistent. > I don’t know which other modes use global-mode-string; is display-time > mode the only outlier? Not at all: grep for that variable in the Emacs source tree, and you will see that most of its users don't start their strings with a blank. Which is why I asked this question: > > But if we want to have a separation there, would it make sense to do > > this in bindings.el, so that global-mode-string is always separated by > > a blank from the preceding text, and modes don't have to remember this > > gork?