From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) Date: Thu, 18 Jan 2018 17:23:29 +0200 Message-ID: <83mv1bur66.fsf@gnu.org> References: <20180117222846.93077-1-phst@google.com> <20180117222846.93077-2-phst@google.com> <83y3kvuuui.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516288973 22959 195.159.176.226 (18 Jan 2018 15:22:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Jan 2018 15:22:53 +0000 (UTC) Cc: phst@google.com, 30106@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 18 16:22:48 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecC1D-0004G8-7O for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 16:22:19 +0100 Original-Received: from localhost ([::1]:36782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecC3D-0006Ht-9c for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jan 2018 10:24:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecC2w-0006Cv-JU for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 10:24:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecC2s-0006fY-Ne for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 10:24:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecC2s-0006fM-Kl for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 10:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecC2s-00086f-Fh for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2018 10:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jan 2018 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30106 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30106-submit@debbugs.gnu.org id=B30106.151628902431137 (code B ref 30106); Thu, 18 Jan 2018 15:24:02 +0000 Original-Received: (at 30106) by debbugs.gnu.org; 18 Jan 2018 15:23:44 +0000 Original-Received: from localhost ([127.0.0.1]:33553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecC2Z-000869-OA for submit@debbugs.gnu.org; Thu, 18 Jan 2018 10:23:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecC2Y-00085x-Qs for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 10:23:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecC2Q-0006Pf-D8 for 30106@debbugs.gnu.org; Thu, 18 Jan 2018 10:23:37 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecC2Q-0006Pb-A3; Thu, 18 Jan 2018 10:23:34 -0500 Original-Received: from [176.228.60.248] (port=4418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecC2P-0004mb-Nh; Thu, 18 Jan 2018 10:23:34 -0500 In-reply-to: (message from Philipp Stephani on Thu, 18 Jan 2018 14:23:03 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142255 Archived-At: > From: Philipp Stephani > Date: Thu, 18 Jan 2018 14:23:03 +0000 > Cc: phst@google.com, 30106@debbugs.gnu.org > > I'd prefer that the only file that calls systhread.c functions is > thread.c; systhread.c is supposed to be low-level code concealed from > application levels. So this would call for another level of > indirection: add a new function to thread.c, and call that from > emacs-module.c. > > Makes sense, I've moved in_current_thread to thread.c because it's unrelated to modules. Thanks. > Otherwise, LGTM for master; thanks. > > Can we push this to emacs-26? Right now emacs-26 can't even be compiled with --without-threads > --with-modules (on some systems at least). How important is this? --with-modules is an opt-in switch, and the default is to build with threads. So this sounds not very important to me, and the change, although simple, is not really trivial, and will affect any module. So I'm uneasy putting this on emacs-26, especially since the Emacs 26.0.91 tarball is already ready and is awaiting upload, so this will only go into the next pretest, which I hoped could be a release candidate... Do you think leaving this for the next release will be so bad?