unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: John Wiegley <johnw@gnu.org>
Cc: 30139@debbugs.gnu.org, k.michal@zoho.com
Subject: bug#30139: 25.3; Passing callback to align-region raises an error when using `justify` rule
Date: Sat, 24 Feb 2018 12:21:04 +0200	[thread overview]
Message-ID: <83muzy4rjj.fsf@gnu.org> (raw)
In-Reply-To: <83woz65h7b.fsf@gnu.org> (message from Eli Zaretskii on Wed, 21 Feb 2018 20:30:00 +0200)

> Date: Wed, 21 Feb 2018 20:30:00 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 30139@debbugs.gnu.org
> 
> > From: Michał Kondraciuk <k.michal@zoho.com>
> > Date: Tue, 20 Feb 2018 22:07:10 +0100
> > 
> > is there any news on the status of this bug? Should I just send the 
> > patch to emacs-devel?
> 
> Sorry for the delay, I will look at the patch soon.

John, could you please have a look at this?

Btw, I find the documentation in align.el hard to understand.  It
sounds like a very powerful feature, but I would have difficulties
using it, with the doc strings as my only guidance.  Some examples of
unclear or confusing documentation:

 . align-region-separate has this to describe the 'group' method:

     Each contiguous set of lines where a specific alignment occurs is
     considered a section for that alignment rule.

   What is a "contiguous set of lines"?  Does it mean non-empty lines,
   i.e. that groups are separated by empty lines (that's what the
   example seems to imply)?

 . align-rules-list has this to describe the 'group' attribute:

     [...]  For alignment rules, these are the characters that will be
     deleted/expanded for the purposes of alignment.  The "alignment
     character" is always the first character immediately following
     this parenthesis group.  This attribute may also be a list of
     integers, in which case multiple alignment characters will be
     aligned, with the list of integers identifying the whitespace
     groups which precede them.  The default for this attribute is 1.

   Which "this parenthesis group" is being alluded to here?  Also, it
   leaves unexplained how characters are specified by integers, and
   the meaning of the default value of 1 is thus unclear.

So patches to clarify the documentation in align.el are most welcome.





  reply	other threads:[~2018-02-24 10:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 20:23 bug#30139: 25.3; Passing callback to align-region raises an error when using `justify` rule Michał Kondraciuk
2018-01-19 17:04 ` Michał Kondraciuk
     [not found] ` <639293e7-4cd9-9297-1ad6-ceba6697a627@zoho.com>
2018-02-20 21:07   ` Michał Kondraciuk
2018-02-21 18:30     ` Eli Zaretskii
2018-02-24 10:21       ` Eli Zaretskii [this message]
2018-03-03 11:11         ` Eli Zaretskii
2018-03-19  9:19           ` Eli Zaretskii
2018-03-20  0:43         ` John Wiegley
2018-03-20  0:39     ` John Wiegley
2018-04-01  9:51       ` Eli Zaretskii
2018-04-03 17:47         ` John Wiegley
2019-06-24 20:10       ` Lars Ingebrigtsen
2019-09-18 14:00         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83muzy4rjj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30139@debbugs.gnu.org \
    --cc=johnw@gnu.org \
    --cc=k.michal@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).