unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size
Date: Fri, 13 Apr 2018 15:43:14 +0300	[thread overview]
Message-ID: <83muy75lb1.fsf@gnu.org> (raw)
In-Reply-To: <87fu3z9vjt.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Fri, 13 Apr 2018 13:48:22 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: jidanni@jidanni.org,  30675@debbugs.gnu.org
> Date: Fri, 13 Apr 2018 13:48:22 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I'd feel much better with a lower factor, e.g. some value that is just
> > enough to cover this case plus some slack.  Bonus points for providing
> > a defcustom with the factor, so that users could change that.
> 
> The problem is that HTML may nest arbitrarily deep, so there isn't
> really any way to cover this completely.  But the larger the stack size
> is, the lower the possibility for hitting the limit is.
> 
> FWIW, I haven't hit the limit in about a year, so it's rare for people
> to encounter HTML that's that deeply nested.

Which probably means ten-fold increase is too much.  Would increasing
the limit twice fix this problem?  If so, then let's do that in
shr.el.

> why consult the user at all?  :-)

Because there's a possibility of infinite recursion.  So the question
actually boils down to "how much do you trust the code which caused
this?"  And I'm guessing the answer will tend to be NO with each
additional prompt from the same command.





  parent reply	other threads:[~2018-04-13 12:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877eqwbqvc.fsf@jidanni.org>
     [not found] ` <b4mfu5kk0iz.fsf@jpl.org>
2018-03-02  2:40   ` bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size 積丹尼 Dan Jacobson
2018-03-02  2:51     ` Noam Postavsky
2018-04-12 23:49     ` Lars Ingebrigtsen
2018-04-13  0:06       ` 積丹尼 Dan Jacobson
2018-04-13  0:27         ` Lars Ingebrigtsen
2018-04-13  9:29           ` Eli Zaretskii
2018-04-13 11:48             ` Lars Ingebrigtsen
2018-04-13 12:15               ` Noam Postavsky
2018-04-13 12:32                 ` Lars Ingebrigtsen
2018-04-13 12:43               ` Eli Zaretskii [this message]
2018-04-13 15:34                 ` Lars Ingebrigtsen
2018-04-15 17:02                   ` Lars Ingebrigtsen
2018-04-13 12:40             ` 積丹尼 Dan Jacobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83muy75lb1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30675@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).