From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Tue, 22 May 2018 05:37:50 +0300 Message-ID: <83muwse7pd.fsf@gnu.org> References: <83d0xti993.fsf@gnu.org> <83bmddi2ad.fsf@gnu.org> <83603lhrvw.fsf@gnu.org> <8336yoiuf4.fsf@gnu.org> <831se6hjnh.fsf@gnu.org> <83h8n1g2hm.fsf@gnu.org> <42fe26038dde2b56636888cfbf4e37bb@webmail.orcon.net.nz> <83603hf1w9.fsf@gnu.org> <51c17257ab43917d561cc5e56a556d67@webmail.orcon.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1526956633 4662 195.159.176.226 (22 May 2018 02:37:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 May 2018 02:37:13 +0000 (UTC) Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm, bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org, michael@mauger.com To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 22 04:37:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKxAf-000127-L1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 May 2018 04:37:05 +0200 Original-Received: from localhost ([::1]:53270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKxCl-0003yo-2g for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2018 22:39:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKxCb-0003yX-Lg for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 22:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKxCY-0008Vr-J1 for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 22:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKxCY-0008Vj-EZ for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 22:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKxCY-00028c-77 for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 22:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 May 2018 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.15269566878156 (code B ref 31446); Tue, 22 May 2018 02:39:02 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 22 May 2018 02:38:07 +0000 Original-Received: from localhost ([127.0.0.1]:43411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKxBe-00027T-Vn for submit@debbugs.gnu.org; Mon, 21 May 2018 22:38:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKxBd-000271-LO for 31446@debbugs.gnu.org; Mon, 21 May 2018 22:38:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKxBV-0008Ff-Fl for 31446@debbugs.gnu.org; Mon, 21 May 2018 22:38:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKxBM-0008DM-0w; Mon, 21 May 2018 22:37:48 -0400 Original-Received: from [176.228.60.248] (port=3693 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fKxBL-0000v5-F5; Mon, 21 May 2018 22:37:47 -0400 In-reply-to: <51c17257ab43917d561cc5e56a556d67@webmail.orcon.net.nz> (message from Phil Sainty on Tue, 22 May 2018 10:08:05 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146364 Archived-At: > Date: Tue, 22 May 2018 10:08:05 +1200 > From: Phil Sainty > Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm, > bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org, michael@mauger.com > > On 2018-05-22 03:45, Eli Zaretskii wrote: > > Thanks, I tried fixing it in a slightly different way, please take a > > look. I'd like to avoid releasing Emacs 26.1 with sql.el that was > > broken by latest changes. > > That seems to work, except for regressing this bit: > > >> I *think* we'd want (consp new-name) for that test (especially as > >> it ought to cover multiple uses of C-u) > > With C-u C-u M-x sql-postgres I end up with buffer name "*SQL: (16)*" > and "Process SQL: (16) finished" etc. What is "C-u C-u" sup[posed to achieve? It isn't called out in the doc strings, AFAICS, is it? > Another difference from Emacs 25 is that using a prefix arg in Emacs 25 > was guaranteed to create a new buffer/process (if the chosen buffer name > conflicted then it was uniquified), whereas the new code is switching to > the pre-existing buffer in the situation. This will have to be dealt with after Emacs 26.1 release. Thanks.