From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 32002@debbugs.gnu.org, kurn@sfu.ca, mkupfer@alum.berkeley.edu
Subject: bug#32002: 24.4; Scroll bar start, end not correct
Date: Sat, 21 Jul 2018 16:50:39 +0300 [thread overview]
Message-ID: <83muuky9xs.fsf@gnu.org> (raw)
In-Reply-To: <5B49ADC5.9020006@gmx.at> (message from martin rudalics on Sat, 14 Jul 2018 10:01:09 +0200)
> Date: Sat, 14 Jul 2018 10:01:09 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: 32002@debbugs.gnu.org, kurn@sfu.ca
>
> Right, presumably. What happens here is that in 'scroll-bar-drag-1'
> we go to 'point-max' since 'portion-whole' is (1 . 1) and
> 'scroll-bar-scale' returns WHOLE in that case and set the start
> position of that window to 'point-max'. If, in that case, we do
> nothing as in
>
> (defun scroll-bar-drag-1 (event)
> (let* ((start-position (event-start event))
> (window (nth 0 start-position))
> (portion-whole (nth 2 start-position)))
> (unless (= (car portion-whole) (cdr portion-whole))
> (save-excursion
> (with-current-buffer (window-buffer window)
> ;; Calculate position relative to the accessible part of the buffer.
> (goto-char (+ (point-min)
> (scroll-bar-scale portion-whole
> (- (point-max) (point-min)))))
> (vertical-motion 0 window)
> (set-window-start window (point)))))))
>
> the problem is resolved. But I'm afraid that I understand too little
> about overscrolling and the portion/whole stuff to confidently
> recommend such a solution. Hopefully, you will come up with a better
> one.
Not sure I follow: for the problem to be resolved, we need to set
window-start to some position that is not point-max. So who does that
setting in the case in point, with your change in effect?
Or did you mean to disable scrolling-up in this case, and thus remove
the need for scrolling down? Hmm... maybe that's the only solution to
this conundrum, but in that case I think it would be safer to add
scroll-bar-adjust-thumb-portion to your condition about portion-whole.
next prev parent reply other threads:[~2018-07-21 13:50 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 7:36 bug#32002: 24.4; Scroll bar start, end not correct Andrew Kurn
2018-06-29 8:53 ` Eli Zaretskii
[not found] ` <20180629162402.GA21197@sfu.ca>
2018-06-29 17:24 ` Eli Zaretskii
2018-07-01 1:30 ` Andrew Kurn
2018-07-02 18:16 ` Glenn Morris
2018-07-02 18:20 ` Glenn Morris
2018-07-03 12:58 ` Andrew Kurn
2018-07-04 2:00 ` Noam Postavsky
2018-07-04 3:45 ` Andrew Kurn
2018-07-04 4:59 ` Eli Zaretskii
2018-07-04 5:13 ` Mike Kupfer
2018-07-04 5:34 ` Eli Zaretskii
2018-07-04 16:32 ` Mike Kupfer
2018-07-04 23:36 ` Mike Kupfer
2018-07-04 23:44 ` Noam Postavsky
2018-07-04 23:56 ` Mike Kupfer
2018-07-05 2:36 ` Eli Zaretskii
2018-07-05 5:28 ` Mike Kupfer
2018-07-05 6:27 ` Eli Zaretskii
2018-07-05 15:05 ` Mike Kupfer
2018-07-06 3:58 ` Mike Kupfer
2018-07-06 6:10 ` Eli Zaretskii
2018-07-06 10:32 ` Robert Pluim
2018-07-06 12:56 ` martin rudalics
2018-07-06 13:31 ` Eli Zaretskii
2018-07-07 7:15 ` martin rudalics
2018-07-07 7:35 ` Eli Zaretskii
2018-07-07 7:47 ` martin rudalics
2018-07-07 15:19 ` Mike Kupfer
2018-07-07 15:59 ` Eli Zaretskii
2018-07-07 23:05 ` Mike Kupfer
2018-07-08 3:00 ` Mike Kupfer
2018-07-07 16:00 ` Mike Kupfer
2018-07-08 8:11 ` martin rudalics
2018-07-09 1:42 ` Mike Kupfer
2018-07-09 2:53 ` Mike Kupfer
2018-07-09 8:34 ` martin rudalics
2018-07-09 8:34 ` martin rudalics
2018-07-09 14:39 ` Mike Kupfer
2018-07-10 7:30 ` martin rudalics
2018-07-14 4:31 ` Mike Kupfer
2018-07-14 8:00 ` martin rudalics
2018-07-21 0:28 ` Mike Kupfer
2018-07-21 7:44 ` martin rudalics
2018-07-14 4:13 ` Mike Kupfer
2018-07-06 15:02 ` Mike Kupfer
2018-07-06 16:02 ` Robert Pluim
2018-07-07 7:17 ` martin rudalics
2018-07-04 7:49 ` Andrew Kurn
2018-07-04 9:30 ` Stephen Berman
2018-07-04 12:10 ` Noam Postavsky
2018-07-04 16:34 ` Mike Kupfer
2018-07-10 19:16 ` Andrew Kurn
2018-07-11 3:02 ` Eli Zaretskii
2018-07-12 7:11 ` Andrew Kurn
2018-07-12 13:29 ` Eli Zaretskii
2018-07-12 15:57 ` Stephen Berman
2018-07-12 16:35 ` Eli Zaretskii
2018-07-14 4:56 ` Mike Kupfer
2018-07-14 6:49 ` Eli Zaretskii
2018-07-14 8:01 ` martin rudalics
2018-07-21 13:50 ` Eli Zaretskii [this message]
2018-07-22 7:25 ` martin rudalics
2018-07-22 14:55 ` Eli Zaretskii
2018-07-23 6:51 ` martin rudalics
2018-07-27 8:30 ` Eli Zaretskii
2018-07-27 9:23 ` martin rudalics
2018-07-27 11:03 ` Andrew Kurn
2018-07-27 12:27 ` Eli Zaretskii
2018-07-28 7:22 ` martin rudalics
2018-07-29 2:51 ` Mike Kupfer
2018-07-16 1:47 ` Mike Kupfer
2018-07-21 13:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83muuky9xs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32002@debbugs.gnu.org \
--cc=kurn@sfu.ca \
--cc=mkupfer@alum.berkeley.edu \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).