From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29189: 25.3; Dired does not work with binary filenames Date: Sun, 09 Sep 2018 09:12:28 +0300 Message-ID: <83musrqjw3.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536473982 7199 195.159.176.226 (9 Sep 2018 06:19:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2018 06:19:42 +0000 (UTC) Cc: 29189-done@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 09 08:19:38 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyt4M-0001mA-4k for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Sep 2018 08:19:38 +0200 Original-Received: from localhost ([::1]:46218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyt6S-0006gh-KL for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Sep 2018 02:21:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyt6C-0006ZF-VZ for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 02:21:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fysxz-0001ky-15 for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 02:13:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45779) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fysxy-0001kh-S2 for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 02:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fysxy-0006Qp-MX for bug-gnu-emacs@gnu.org; Sun, 09 Sep 2018 02:13:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Sep 2018 06:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 29189@debbugs.gnu.org, eliz@gnu.org, vianchielfaura@gmail.com Original-Received: via spool by 29189-done@debbugs.gnu.org id=D29189.153647356024690 (code D ref 29189); Sun, 09 Sep 2018 06:13:02 +0000 Original-Received: (at 29189-done) by debbugs.gnu.org; 9 Sep 2018 06:12:40 +0000 Original-Received: from localhost ([127.0.0.1]:50796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fysxY-0006Q6-DD for submit@debbugs.gnu.org; Sun, 09 Sep 2018 02:12:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fysxW-0006Pt-Gb for 29189-done@debbugs.gnu.org; Sun, 09 Sep 2018 02:12:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fysxN-0008I9-5b for 29189-done@debbugs.gnu.org; Sun, 09 Sep 2018 02:12:29 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fysxL-0008Ey-MJ; Sun, 09 Sep 2018 02:12:25 -0400 Original-Received: from [176.228.60.248] (port=3624 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fysxL-00076x-9B; Sun, 09 Sep 2018 02:12:23 -0400 In-reply-to: (message from Allen Li on Sat, 8 Sep 2018 17:31:14 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150152 Archived-At: > From: Allen Li > Date: Sat, 8 Sep 2018 17:31:14 -0700 > > I believe this bug was fixed in 26? Yes. I even sent a message to that effect at the time I pushed the changes, but I see now that I goofed with the bug address, so neither the message nor the instruction to close the bug made it to the bug tracker. Reproducing the important part below: > From: Stefan Monnier > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org, schwab@suse.de > Date: Fri, 05 Jan 2018 17:16:30 -0500 > > > I found that the alternative patch below solves the original problem > > without any changes needed in files.el, and without introducing any > > performance hits. Does anyone see a problem with this proposed patch? > > [ With Andreas's adjustment] It looks sane to me. I'd still want Handa-san's review of the patch, but I went ahead and pushed it to the emacs-26 branch, and I'm closing the bug. Thanks for pointing out this blunder.