From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33230: 26.1; Soft-wrap issue in term.el with term-suppress-hard-newline Date: Tue, 13 Nov 2018 19:18:12 +0200 Message-ID: <83muqc99rf.fsf@gnu.org> References: <87h8h0if4u.fsf@gmail.com> <87bm76j496.fsf@gmail.com> <5BDEB6CD.2050407@gmx.at> <5BDEC244.3040002@gmx.at> <5BEA9469.7080502@gmx.at> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1542129772 11917 195.159.176.226 (13 Nov 2018 17:22:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2018 17:22:52 +0000 (UTC) Cc: 33230@debbugs.gnu.org, bruno@charron.email, npostavs@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 13 18:22:48 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMcOm-0002ze-2M for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Nov 2018 18:22:48 +0100 Original-Received: from localhost ([::1]:55312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMcQs-0005yG-BU for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Nov 2018 12:24:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMcLB-0001cY-37 for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2018 12:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMcL8-00016v-59 for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2018 12:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMcL7-00016n-W8 for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2018 12:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gMcL7-0004J2-RS for bug-gnu-emacs@gnu.org; Tue, 13 Nov 2018 12:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Nov 2018 17:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 33230-submit@debbugs.gnu.org id=B33230.154212951616517 (code B ref 33230); Tue, 13 Nov 2018 17:19:01 +0000 Original-Received: (at 33230) by debbugs.gnu.org; 13 Nov 2018 17:18:36 +0000 Original-Received: from localhost ([127.0.0.1]:50562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMcKh-0004IL-Uj for submit@debbugs.gnu.org; Tue, 13 Nov 2018 12:18:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMcKh-0004I6-0t for 33230@debbugs.gnu.org; Tue, 13 Nov 2018 12:18:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMcKP-0000S3-1d for 33230@debbugs.gnu.org; Tue, 13 Nov 2018 12:18:21 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMcKO-0000Rr-T1; Tue, 13 Nov 2018 12:18:16 -0500 Original-Received: from [176.228.60.248] (port=3994 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gMcKO-0000vc-GX; Tue, 13 Nov 2018 12:18:16 -0500 In-reply-to: <5BEA9469.7080502@gmx.at> (message from martin rudalics on Tue, 13 Nov 2018 10:07:53 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152349 Archived-At: > Date: Tue, 13 Nov 2018 10:07:53 +0100 > From: martin rudalics > CC: Noam Postavsky , 33230@debbugs.gnu.org, > "eliz@gnu.org" > > >> Attached find a patch for this against the release branch. Please try > >> it. > > > > Thanks martin, I confirm that after applying your patch on the 26.1 > > release, COLUMNS is correctly updated in the shell at each frame > > resize while it is not without the patch. > > Eli - is this OK to install on the release branch? It restores the > behavior of Emacs 25 to fix a bug introduced in 26.1. I'm too confused about this to be able to make up my mind. Please help me figure out what am I missing. You said up-thread: > > Another issue I found that may need to be addressed to get a behavior > > similar to gnome-terminal above is that the shell is not aware > > (checking $COLUMS) of when the frame is resized, only when its window > > is resized and there is another window on the side. > > FWIW this is Bug#32720 for which I am responsible. It will be fixed > in Emacs 26.2 by reestablishing the behavior of Emacs 25. And your proposed change runs window-configuration-change-hook in two additional places. My confusion about this is twofold: (1) the original report for this bug doesn't seem to involve any resizing of a frame, and (2) the ELisp manual explicitly says that "resizing the frame or individual windows do not count as configuration changes", and thus this hook shouldn't be run when the frame is resized. So how does the proposed change fix the problem at hand, and why do you want to do exactly what the ELisp manual says we don't? Thanks.