From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion Date: Tue, 27 Nov 2018 07:56:51 +0200 Message-ID: <83mupvgj18.fsf@gnu.org> References: <9B715204-BE6D-4F02-B484-1EA9EDACE0EB@scratch.space> <87wope15gh.fsf@mail.linkov.net> <4D07BB6C-98A9-4EC2-BB37-097D5D753E53@scratch.space> <87wopbzeuy.fsf@mail.linkov.net> <87d0r04tmg.fsf@mail.linkov.net> <87sgzv747k.fsf@mail.linkov.net> <740AF1DA-7EDB-4310-8C6E-F7944D714513@scratch.space> <87sgzuca5o.fsf@mail.linkov.net> <87a7m0hi5t.fsf@mail.linkov.net> <837eh4gpjd.fsf@gnu.org> <87a7lyi29o.fsf@mail.linkov.net> <837eh1jeak.fsf@gnu.org> <87k1l0c3be.fsf@mail.linkov.net> <83h8g3j0aa.fsf@gnu.org> <87y39fmnbn.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1543298130 18427 195.159.176.226 (27 Nov 2018 05:55:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2018 05:55:30 +0000 (UTC) Cc: van@scratch.space, 33398@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 27 06:55:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRWLE-0004hD-Ib for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Nov 2018 06:55:24 +0100 Original-Received: from localhost ([::1]:40141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRWNJ-0006Gp-He for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Nov 2018 00:57:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRWMv-00067m-FH for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 00:57:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRWMp-0007bs-Dy for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 00:57:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRWMp-0007bj-3j for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 00:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRWMp-0003kT-2b for bug-gnu-emacs@gnu.org; Tue, 27 Nov 2018 00:57:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Nov 2018 05:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33398-submit@debbugs.gnu.org id=B33398.154329821614388 (code B ref 33398); Tue, 27 Nov 2018 05:57:03 +0000 Original-Received: (at 33398) by debbugs.gnu.org; 27 Nov 2018 05:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:50360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRWMi-0003jz-7T for submit@debbugs.gnu.org; Tue, 27 Nov 2018 00:56:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRWMg-0003jm-9L for 33398@debbugs.gnu.org; Tue, 27 Nov 2018 00:56:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRWMW-0007XN-R9 for 33398@debbugs.gnu.org; Tue, 27 Nov 2018 00:56:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRWMW-0007XH-Ob; Tue, 27 Nov 2018 00:56:44 -0500 Original-Received: from [176.228.60.248] (port=4633 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRWMW-0002Om-CZ; Tue, 27 Nov 2018 00:56:44 -0500 In-reply-to: <87y39fmnbn.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 27 Nov 2018 01:27:40 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152812 Archived-At: > From: Juri Linkov > Cc: Van L , 33398@debbugs.gnu.org > Date: Tue, 27 Nov 2018 01:27:40 +0200 > > > So your problem is with the names of the faces? Then may I suggest to > > name the new faces hi-red and hi-deepblue? > > Maybe something like this, but I'm not sure because the red background would > be too glaring on 88 colors, but more readable orchid1 is not quite red. Is OrangeRed better? > Also blue would be too dark for a light background, but more readable > DarkSlateGray1 is not quite blue as its name suggests. That's okay, I think. > (defface hi-green-b > - '((((min-colors 88)) (:weight bold :foreground "green1")) > + '((((min-colors 88)) (:weight bold :foreground "green3")) > (t (:weight bold :foreground "green"))) > "Face for hi-lock mode." > :group 'hi-lock-faces) > > (defface hi-red-b > - '((((min-colors 88)) (:weight bold :foreground "red1")) > + '((((min-colors 88)) (:weight bold :foreground "firebrick2")) > (t (:weight bold :foreground "red"))) > "Face for hi-lock mode." > :group 'hi-lock-faces) So why are you still changing the existing faces? Not that I see any problem with these changes on low-color TTYs, but still: why change?