From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33669: 26.1; Buffer-menu-mode bad UX Date: Sat, 22 Dec 2018 12:50:10 +0200 Message-ID: <83muoxal99.fsf@gnu.org> References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> <83tvjo46pt.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545475752 4402 195.159.176.226 (22 Dec 2018 10:49:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 10:49:12 +0000 (UTC) Cc: 33669@debbugs.gnu.org To: Devon Sean McCullough Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 11:49:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaeqB-00012j-TM for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 11:49:08 +0100 Original-Received: from localhost ([::1]:50694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaesH-0001Pr-L1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 05:51:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaes5-0001ON-Nx for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 05:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaes2-0003lI-FN for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 05:51:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54938) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gaes2-0003kn-B7 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 05:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gaes2-0007vB-4k for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 05:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33669-submit@debbugs.gnu.org id=B33669.154547583630415 (code B ref 33669); Sat, 22 Dec 2018 10:51:02 +0000 Original-Received: (at 33669) by debbugs.gnu.org; 22 Dec 2018 10:50:36 +0000 Original-Received: from localhost ([127.0.0.1]:59196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaerb-0007uV-Uh for submit@debbugs.gnu.org; Sat, 22 Dec 2018 05:50:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaerb-0007uH-5k for 33669@debbugs.gnu.org; Sat, 22 Dec 2018 05:50:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaerS-0003Fp-Kt for 33669@debbugs.gnu.org; Sat, 22 Dec 2018 05:50:29 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaerQ-0003Dw-ME; Sat, 22 Dec 2018 05:50:24 -0500 Original-Received: from [176.228.60.248] (port=1593 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gaerQ-0007YB-9a; Sat, 22 Dec 2018 05:50:24 -0500 In-reply-to: <83tvjo46pt.fsf@gnu.org> (message from Eli Zaretskii on Sat, 08 Dec 2018 13:07:42 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153730 Archived-At: Ping! Devon, could you please try the proposed fix? > Date: Sat, 08 Dec 2018 13:07:42 +0200 > From: Eli Zaretskii > Cc: 33669@debbugs.gnu.org > > > From: Devon Sean McCullough > > Date: Sat, 8 Dec 2018 10:06:48 +0800 > > > > When Buffer-menu-execute asks > > > > Buffer foo modified; kill anyway? (yes or no) > > > > and the reply is no, > > that line is removed anyway, deceiving the user > > by making the buffer menu incorrect. > > > > The user will promptly seek out such buffers — but they disappeared, > > giving the distressing wrong impression that they were killed anyway. > > Thanks for reporting this. Does the patch below give good results? > > diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el > index bc1288a..95746b3 100644 > --- a/lisp/buff-menu.el > +++ b/lisp/buff-menu.el > @@ -476,9 +476,10 @@ Buffer-menu-execute > (tabulated-list-set-col 2 " " t)) > (error (warn "Error saving %s" buffer)))) > (if delete > - (unless (eq buffer (current-buffer)) > - (kill-buffer buffer) > - (tabulated-list-delete-entry)) > + (if (and (not (eq buffer (current-buffer))) > + (kill-buffer buffer)) > + (tabulated-list-delete-entry) > + (forward-line 1)) > (forward-line 1))))))))) > > (defun Buffer-menu-select () > > > >