From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37630: 27.0.50; image-mode-fit-frame doesn't Date: Tue, 08 Oct 2019 12:13:53 +0300 Message-ID: <83mueby4z2.fsf@gnu.org> References: <83v9t34kxv.fsf@gnu.org> <877e5hb3yo.fsf@gnus.org> <01C6CC54-E926-470A-9736-41498FC7A25F@gnu.org> <871rvp86ks.fsf@gnus.org> <83sgo4zfnf.fsf@gnu.org> <0d475083-0f51-ed60-95f4-970fa67df241@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238823"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, 37630@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 11:15:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHlaP-000zpo-Di for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 11:15:17 +0200 Original-Received: from localhost ([::1]:52732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHlaN-0004mV-VU for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 05:15:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34433) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHlaF-0004lx-1f for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHlaA-00065d-5Q for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:15:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHlaA-00065O-2U for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHla9-0002O5-Ss for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 09:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37630 X-GNU-PR-Package: emacs Original-Received: via spool by 37630-submit@debbugs.gnu.org id=B37630.15705260459089 (code B ref 37630); Tue, 08 Oct 2019 09:15:01 +0000 Original-Received: (at 37630) by debbugs.gnu.org; 8 Oct 2019 09:14:05 +0000 Original-Received: from localhost ([127.0.0.1]:49531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHlZF-0002MX-7d for submit@debbugs.gnu.org; Tue, 08 Oct 2019 05:14:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHlZD-0002Lu-F5 for 37630@debbugs.gnu.org; Tue, 08 Oct 2019 05:14:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iHlZ7-0004j4-7z; Tue, 08 Oct 2019 05:13:57 -0400 Original-Received: from [176.228.60.248] (port=4453 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iHlZ6-0001KY-Eh; Tue, 08 Oct 2019 05:13:57 -0400 In-reply-to: <0d475083-0f51-ed60-95f4-970fa67df241@gmx.at> (message from martin rudalics on Tue, 8 Oct 2019 10:43:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168621 Archived-At: > Cc: 37630@debbugs.gnu.org > From: martin rudalics > Date: Tue, 8 Oct 2019 10:43:51 +0200 > > > I hope Martin will help us out here. > > If he only could (I don't use Emacs for images). On my MSYS 64 bit > build, I can't display splash.svg getting the somewhat vague error > > Using vacuous schema > Type C-c C-c or C-c C-x to view the image as an image or hex. > Cannot display image: (Invalid image specification) Are you unable to display SVG images in general? Anyway, I get the same incorrect behavior if I use splash.png. I don't think it matters which image format of the splash image you use, you will get the same behavior. So just use whatever image types your build supports. > When I instead try to display some jpg image here via C-x C-f I first > get a separate frame which is slightly larger than that image: When I > now do M-x image-mode-fit-frame in that frame, the frame resizes as > expected without any cropping. Which JPG image did you use? > Looking at the code of 'image-mode-fit-frame' I can't find anything > wrong with > > (set-frame-height frame (+ (ceiling (cdr size)) > height (- inner-height))) > > and would be surprised if this failed unless some frame properties > changed in between the 'frame-height' and the 'window-inside-edges' > calls. Maybe it's also the strange saving modus that interferes in > your setups. The > > (list (cons (frame-width) > (frame-height)) > > doesn't look like TRT when FRAME is not the selected frame but so far > I have no idea how this code is supposed to behave at all. In either > case, make sure the 'image-mode-saved-params' parameter is nil before > calling 'image-mode-fit-frame'. My recipe is in "emacs -Q", so I guess this condition holds?