From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Fri, 22 Nov 2019 23:03:41 +0200 Message-ID: <83mucnvd1u.fsf@gnu.org> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> <834kywxtr1.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1765"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 22:04:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYG69-0000FR-4t for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 22:04:13 +0100 Original-Received: from localhost ([::1]:54922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYG67-0007t7-HP for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 16:04:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59682) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYG61-0007qj-5d for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 16:04:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYG60-0006Te-5e for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 16:04:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYG60-0006Ta-2L for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 16:04:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYG5z-0003t2-Nw for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 16:04:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 21:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157445661714905 (code B ref 38044); Fri, 22 Nov 2019 21:04:03 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 21:03:37 +0000 Original-Received: from localhost ([127.0.0.1]:55585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYG5Z-0003sK-As for submit@debbugs.gnu.org; Fri, 22 Nov 2019 16:03:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYG5V-0003s6-Mf for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 16:03:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYG5P-0006Ep-Po; Fri, 22 Nov 2019 16:03:27 -0500 Original-Received: from [176.228.60.248] (port=4584 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYG5O-0008VB-EM; Fri, 22 Nov 2019 16:03:27 -0500 In-reply-to: (message from Dmitry Gutov on Fri, 22 Nov 2019 21:59:14 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172262 Archived-At: > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Fri, 22 Nov 2019 21:59:14 +0200 > > >> I don't mind this too much (asking vc-git-print-log to include the diffs > >> makes sense, at least), but doing it this way loses out on the > >> opportunity to support all backends in one fell swoop. > > > > I don't understand why would we lose that opportunity. We will have > > to write new code for each backend in any alternative, > > Not necessarily. See the attached patch (it's a modification of Juri's). > > Since we don't have a way to combine async process invocation, there is > some complexity there with accept-process-output. But from what I see, > the diff operation is considerably more resource-intensive, at least for > big Hg repos. > > There is a catch, however: it requires an implementation of > region-history-mode. But, as you remarked, it can be extracted to be > more backend-independent. > > Consequently, for now this "default" implementation only adds > print-revision support to Hg. I'd prefer to use "log -p" in the backend ("log --diff" for svn), because that yields a single command and will work for all the backends except RCS and CVS. The latter two can use "diff". Thanks.