From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: 39373@debbugs.gnu.org
Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding
Date: Sat, 01 Feb 2020 21:28:14 +0200 [thread overview]
Message-ID: <83mua2hzu9.fsf@gnu.org> (raw)
In-Reply-To: <3FB58E0B-E1DB-4709-98AB-92A45508486A@acm.org> (message from Mattias Engdegård on Sat, 1 Feb 2020 20:24:56 +0100)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Sat, 1 Feb 2020 20:24:56 +0100
> Cc: 39373@debbugs.gnu.org
>
> It all seems rather fragile to me, and I'd rather add a note about not using add-to-list for lexical variables to its doc string and the manual, and fix all the calls listed above.
I tend to agree. Stefan, any comments?
> Two patches attached: a doc update, and a replacement of add-to-list in the cases listed above.
LGTM, on both counts, but let's hear from Stefan (and others, if
someone has an opinion).
Thanks.
next prev parent reply other threads:[~2020-02-01 19:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:08 bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Mattias Engdegård
2020-01-31 19:27 ` Eli Zaretskii
2020-01-31 19:38 ` Mattias Engdegård
2020-01-31 20:25 ` Eli Zaretskii
2020-01-31 20:51 ` Mattias Engdegård
2020-02-01 7:48 ` Eli Zaretskii
2020-02-01 15:53 ` Drew Adams
2020-02-01 19:24 ` Mattias Engdegård
2020-02-01 19:28 ` Eli Zaretskii [this message]
2020-02-01 20:15 ` Stefan Monnier
2020-02-01 21:40 ` Mattias Engdegård
2020-02-02 3:31 ` Eli Zaretskii
2020-02-02 11:58 ` Mattias Engdegård
2020-02-02 13:55 ` Stefan Monnier
2020-02-02 14:14 ` Mattias Engdegård
2020-08-09 11:39 ` Lars Ingebrigtsen
2020-08-09 13:28 ` Mattias Engdegård
2020-08-09 19:42 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mua2hzu9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=39373@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).