unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#39911: 27.0.90; error in wisent-total-conflicts if no source filename
@ 2020-03-04 17:23 Neil Okamoto
  2020-03-05  9:50 ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Neil Okamoto @ 2020-03-04 17:23 UTC (permalink / raw)
  To: 39911

[-- Attachment #1: Type: text/plain, Size: 2339 bytes --]


This bug was detected while running docker.el and other packages that depend on tablist [1].  Tablist is an extension of tabulated-list-mode that provides the ability to filter the tabulated list via an expression language. I am not the author of tablist however the author is aware of this issue.

In 27.0.90, tablist is now giving an error when entering its expression editor.  In the debugger I traced the error to wisent-total-conflicts in lisp/cedet/semantic/wisent/comp.el line 2273, in commit 390b4bc1e25fe691548d7ec982eb2f7027fe26a3 [2].  That commit introduced a mechanism to ignore “expected conflicts” via a symbol whose name is constructed on the fly like this:

    (format "wisent-%s--expected-conflicts"
                                     (replace-regexp-in-string "\\.el$" "" src)

However, this code doesn’t handle the case where the filename “src” is nil.

To reproduce the issue, compile a grammar like this:

    (require 'semantic/wisent/comp)
    (require 'semantic/wisent/wisent)

    (defvar tablist-filter-wisent-grammar
      '(
        ;; terminals
        ;; Use lowercase for better looking error messages.
        (operand unary-operator binary-operator or and not)

        ;; terminal associativity & precedence
        ((left binary-operator)
         (left unary-operator)
         (left or)
         (left and)
         (left not))

        ;; rules
        (filter-or-empty
         ((nil))
         ((?\( ?\)) nil)
         ((filter) $1))
        (filter
         ((operand) $1) ;;Named filter
         ((operand binary-operator operand) `(,(intern $2) ,$1 ,$3))
         ((unary-operator operand) `(,(intern $1) ,$2))
         ((not filter) `(not ,$2))
         ((filter and filter) `(and ,$1 ,$3))
         ((filter or filter) `(or ,$1 ,$3))
         ((?\( filter ?\)) $2))))

    (wisent-compile-grammar tablist-filter-wisent-grammar)

    ;; error => “replace-regexp-in-string: Wrong type argument: arrayp, nil”


Thank you,
Neil

[1] https://github.com/politza/tablist <https://github.com/politza/tablist>
[2] http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=390b4bc1e25fe691548d7ec982eb2f7027fe26a3 <http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=390b4bc1e25fe691548d7ec982eb2f7027fe26a3>



[-- Attachment #2: Type: text/html, Size: 4612 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-15 21:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-04 17:23 bug#39911: 27.0.90; error in wisent-total-conflicts if no source filename Neil Okamoto
2020-03-05  9:50 ` Eli Zaretskii
2020-03-13  9:43   ` Eli Zaretskii
2020-03-14 12:18   ` Lars Ingebrigtsen
2020-03-14 13:01     ` Eli Zaretskii
2020-03-14 15:47       ` Neil Okamoto
2020-03-15 21:59         ` Neil Okamoto

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).