From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40845: SVG rendering issues Date: Sat, 25 Apr 2020 18:46:10 +0300 Message-ID: <83mu6z7em5.fsf@gnu.org> References: <72ebf5eb-6b00-ebb4-dab3-a047e35ae1ae@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, 40845@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 25 17:47:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSN1N-000Lci-EG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 17:47:13 +0200 Original-Received: from localhost ([::1]:39506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSN1M-00048N-GW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 11:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53330) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSN1C-00048G-UO for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 11:47:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSN1C-0005bj-Ja for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 11:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSN1C-0005bT-72 for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 11:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSN1C-0005yf-3Z for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2020 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40845 X-GNU-PR-Package: emacs Original-Received: via spool by 40845-submit@debbugs.gnu.org id=B40845.158782960722950 (code B ref 40845); Sat, 25 Apr 2020 15:47:02 +0000 Original-Received: (at 40845) by debbugs.gnu.org; 25 Apr 2020 15:46:47 +0000 Original-Received: from localhost ([127.0.0.1]:60232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSN0v-0005y4-WC for submit@debbugs.gnu.org; Sat, 25 Apr 2020 11:46:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSN0g-0005xX-EB for 40845@debbugs.gnu.org; Sat, 25 Apr 2020 11:46:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56656) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSN0b-0003ZT-1E; Sat, 25 Apr 2020 11:46:25 -0400 Original-Received: from [176.228.60.248] (port=1769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jSN0Z-00043z-E3; Sat, 25 Apr 2020 11:46:24 -0400 In-Reply-To: (message from Pip Cet on Sat, 25 Apr 2020 14:34:11 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179010 Archived-At: > From: Pip Cet > Date: Sat, 25 Apr 2020 14:34:11 +0000 > Cc: 40845@debbugs.gnu.org > > > 3. The SVG images don't inherit the foreground of the current face; instead, they use a black foreground. > > Also, IIRC, 3 is an rsvg issue. I don't think I understand what item 3 is complaining about. If I visit etc/images/splash.svg, it gets the background color of the default face. So is the complaint that it takes the background from the default face instead of the current face? That should be easy to fix, I think, as this code in svg_load_image shows: Emacs_Color background; Lisp_Object specified_bg = image_spec_value (img->spec, QCbackground, NULL); if (!STRINGP (specified_bg) || !FRAME_TERMINAL (f)->defined_color_hook (f, SSDATA (specified_bg), &background, false, false)) FRAME_TERMINAL (f)->query_frame_background_color (f, &background);