From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Wed, 10 Jun 2020 18:08:32 +0300 Message-ID: <83mu5b5573.fsf@gnu.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <87r1v2aat3.fsf@tromey.com> <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> <83tuzueogo.fsf@gnu.org> <6272275C-560C-4437-90F1-2A8294D27019@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> <83blm0cjlz.fsf@gnu.org> <83367ccf8w.fsf@gnu.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> <83o8pyc4bq.fsf@gnu.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> <83img48ffx.fsf@gnu.org> <83bllw82xt.fsf@gnu.org> <1B0F31C8-1E11-4527-A053-DD2DE8235F58@acm.org> <83wo4g5hz6.fsf@gnu.org> <49B7D7B5-D9E3-4E97-A749-CF5E8D8EE2C6@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, tom@tromey.com, 41544@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 10 17:28:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj2eH-000Tqc-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 17:28:17 +0200 Original-Received: from localhost ([::1]:42808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj2eF-0004nh-Vq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 11:28:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj2Le-0001MV-60 for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 11:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj2Ld-00089W-Qv for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 11:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj2Ld-0000pW-LT for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 11:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2020 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.15918017413183 (code B ref 41544); Wed, 10 Jun 2020 15:09:01 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 10 Jun 2020 15:09:01 +0000 Original-Received: from localhost ([127.0.0.1]:35091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2Lc-0000pG-JV for submit@debbugs.gnu.org; Wed, 10 Jun 2020 11:09:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2La-0000p3-3P for 41544@debbugs.gnu.org; Wed, 10 Jun 2020 11:08:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42167) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj2LT-00088c-MB; Wed, 10 Jun 2020 11:08:51 -0400 Original-Received: from [176.228.60.248] (port=4231 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jj2LS-0004yw-Oy; Wed, 10 Jun 2020 11:08:51 -0400 In-Reply-To: <49B7D7B5-D9E3-4E97-A749-CF5E8D8EE2C6@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 10 Jun 2020 16:51:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181817 Archived-At: > From: Mattias Engdegård > Date: Wed, 10 Jun 2020 16:51:24 +0200 > Cc: Tom Tromey , simenheg@runbox.com, 41544@debbugs.gnu.org > > (defun readable-foreground-color (color) > "Return a readable foreground color for background COLOR." Please make sure the doc string says that the function will return either the black or the white color, depending on which one will contrast better with COLOR. Otherwise it is impossible to know, without looking at the code, that this function can return only these two colors. Other than that, I'm okay with the following parts of your patch: . the changes in list-colors-print . the addition of color-dark-p and the change in readable-foreground-color to use it . the replacement of css--contrasty-color with readable-foreground-color (assuming Tom doesn't object) Please don't install anything else. Thanks.