From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42839: [PATCH] Support displaying line numbers in goto-line Date: Thu, 13 Aug 2020 16:10:26 +0300 Message-ID: <83mu2yn131.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19458"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42839@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 15:11:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6D0g-0004y2-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 15:11:10 +0200 Original-Received: from localhost ([::1]:56234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6D0f-0001Z5-Oy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 09:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6D0Y-0001Xz-Gt for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 09:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6D0Y-0000O0-7R for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 09:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6D0Y-0001tf-2j for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42839-submit@debbugs.gnu.org id=B42839.15973242407259 (code B ref 42839); Thu, 13 Aug 2020 13:11:02 +0000 Original-Received: (at 42839) by debbugs.gnu.org; 13 Aug 2020 13:10:40 +0000 Original-Received: from localhost ([127.0.0.1]:47412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6D0C-0001t0-7R for submit@debbugs.gnu.org; Thu, 13 Aug 2020 09:10:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6D0A-0001sm-7A for 42839@debbugs.gnu.org; Thu, 13 Aug 2020 09:10:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53915) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6D05-0000AR-0J; Thu, 13 Aug 2020 09:10:33 -0400 Original-Received: from [176.228.60.248] (port=1131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6D04-0006Lu-Ay; Thu, 13 Aug 2020 09:10:32 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 12 Aug 2020 23:30:42 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185017 Archived-At: > From: Stefan Kangas > Date: Wed, 12 Aug 2020 23:30:42 -0700 > > + (let ((showing display-line-numbers)) > + (unwind-protect > + (progn > + (when (not showing) > + (display-line-numbers-mode 1)) > + (list (read-number (format "Goto line%s: " buffer-prompt) > + (list default (line-number-at-pos)) > + 'goto-line-history) > + buffer)) > + (when (not showing) > + (display-line-numbers-mode -1))))))) The variable display-line-numbers is not a simple boolean, it can have several values. I think you intended to show absolute line numbers in this case, so just testing whether display-line-numbers is non-nil is not enough. Similarly, restoring the original setting needs more than just a call to display-line-numbers-mode. And this needs a NEWS entry. Other than that, if someone wants this optional feature, why not?