From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 45748@debbugs.gnu.org
Subject: bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces
Date: Sat, 09 Jan 2021 20:03:10 +0200 [thread overview]
Message-ID: <83mtxigf8h.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48yXNMon_Wos+W5zZR-eD=5yYsxivA2=3Lurr2Z6edkyyQ@mail.gmail.com> (message from Aaron Jensen on Sat, 9 Jan 2021 11:44:46 -0600)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Sat, 9 Jan 2021 11:44:46 -0600
> Cc: 45748@debbugs.gnu.org
>
> diff --git a/src/xdisp.c b/src/xdisp.c
> index 6a4304d194..20e7ca3a1e 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -10652,7 +10652,10 @@ DEFUN ("window-text-pixel-size",
> Fwindow_text_pixel_size, Swindow_text_pixel_siz
> {
> c = fetch_char_advance (&start, &bpos);
> if (!(c == ' ' || c == '\t' || c == '\n' || c == '\r'))
> - break;
> + {
> + dec_both (&start, &bpos);
> + break;
> + }
> }
This increments position, then decrements it, which is sub-optimal.
> {
> dec_both (&end, &bpos);
> c = FETCH_BYTE (bpos);
> if (!(c == ' ' || c == '\t' || c == '\n' || c == '\r'))
> - break;
> + {
> + inc_both (&end, &bpos);
> + break;
> + }
> }
Same here.
next prev parent reply other threads:[~2021-01-09 18:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 15:43 bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces Aaron Jensen
2021-01-09 15:57 ` Aaron Jensen
2021-01-09 16:27 ` Aaron Jensen
2021-01-09 17:07 ` martin rudalics
2021-01-09 17:44 ` Aaron Jensen
2021-01-09 17:55 ` Aaron Jensen
2021-01-09 18:14 ` Eli Zaretskii
2021-01-10 2:56 ` Aaron Jensen
2021-01-10 16:05 ` martin rudalics
2021-01-10 17:31 ` Aaron Jensen
2021-01-10 17:49 ` martin rudalics
2021-01-10 17:51 ` Aaron Jensen
2021-01-10 17:57 ` martin rudalics
2021-01-10 17:58 ` Aaron Jensen
2021-01-13 4:34 ` Aaron Jensen
2021-01-13 14:26 ` Eli Zaretskii
2021-01-15 12:11 ` Eli Zaretskii
2021-01-15 12:34 ` Aaron Jensen
2021-01-15 13:15 ` Eli Zaretskii
2021-01-15 14:04 ` Aaron Jensen
2021-01-15 15:37 ` Eli Zaretskii
2021-01-15 17:03 ` Aaron Jensen
2021-01-09 18:03 ` Eli Zaretskii [this message]
2021-01-09 17:44 ` Eli Zaretskii
2021-01-09 17:49 ` Aaron Jensen
2021-01-09 17:07 ` martin rudalics
2021-01-16 17:12 ` bug#45748: [PATCH] * test/src/xdisp-tests.el Fix tests to work in batch mode Aaron Jensen
2021-01-16 17:57 ` Basil L. Contovounesios
2021-01-16 18:24 ` Aaron Jensen
2021-01-16 18:24 ` Aaron Jensen
2021-01-16 18:28 ` Aaron Jensen
2021-01-16 18:28 ` Aaron Jensen
2021-01-16 18:33 ` Eli Zaretskii
2021-01-18 17:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mtxigf8h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45748@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).