From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Sat, 20 Feb 2021 08:57:10 +0200 Message-ID: <83mtvz1b21.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83k0r53ygd.fsf@gnu.org> <83im6o4hrc.fsf@gnu.org> <83tuq82qmb.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22080"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 20 07:58:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDMDS-0005cq-5t for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Feb 2021 07:58:10 +0100 Original-Received: from localhost ([::1]:54930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDMDR-0003cN-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Feb 2021 01:58:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDMDK-0003c9-5D for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 01:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDMDJ-0005Dj-UD for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 01:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDMDJ-0003hV-QE for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 01:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Feb 2021 06:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161380425214189 (code B ref 43725); Sat, 20 Feb 2021 06:58:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 20 Feb 2021 06:57:32 +0000 Original-Received: from localhost ([127.0.0.1]:50846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDMCq-0003gn-2Y for submit@debbugs.gnu.org; Sat, 20 Feb 2021 01:57:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDMCo-0003gb-Br for 43725@debbugs.gnu.org; Sat, 20 Feb 2021 01:57:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39903) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDMCi-0004yc-Tx; Sat, 20 Feb 2021 01:57:24 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lDMCh-0006QE-LB; Sat, 20 Feb 2021 01:57:24 -0500 In-Reply-To: (message from Andrea Corallo on Fri, 19 Feb 2021 22:03:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200398 Archived-At: > From: Andrea Corallo > Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org > Date: Fri, 19 Feb 2021 22:03:32 +0000 > > Okay 14e6268d14 is arranging things as follow: > > #ifdef WIDE_EMACS_INT > if (val > LONG_MAX || val < LONG_MIN) > return emit_rvalue_from_unsigned_long_long (comp.emacs_uint_type, val); > #endif > return gcc_jit_context_new_rvalue_from_long (comp.ctxt, > comp.emacs_uint_type, > val); Thanks. > >> 'emit_rvalue_from_unsigned_long_long' was added by me as libgccjit so > >> far has no long long support. As this is shifting the numeric argument > >> to emit the code that re-create the long long equivalent using an > >> unsigned was the natural choice to avoid UB. > >> > >> Admittedly we could just cast inside > >> 'emit_rvalue_from_unsigned_long_long' and rename it into > >> 'emit_rvalue_from_long_long' but I'm not sure is that important. > > > > Either that, or some comment would be good enough. > > I realized we already had also the signed variant so with 92fe7a91f4 I > removed the unsigned one and we always use 'emit_rvalue_from_long_long' > now. Great, thanks.