From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Thu, 04 Mar 2021 17:13:20 +0200 Message-ID: <83mtvjhrzj.fsf@gnu.org> References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> <9cff0f8894658f3b50c8@heytings.org> <83y2f3huz2.fsf@gnu.org> <9cff0f88942d4103c685@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10082"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 16:19:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHpl9-0002UM-Od for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 16:19:27 +0100 Original-Received: from localhost ([::1]:59298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHpl8-0004hU-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 10:19:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHpfu-00071p-Fq for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 10:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHpfu-00024V-6R for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 10:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHpfu-0007dJ-0E for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 10:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161487082629310 (code B ref 46859); Thu, 04 Mar 2021 15:14:01 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 4 Mar 2021 15:13:46 +0000 Original-Received: from localhost ([127.0.0.1]:59941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHpfe-0007cg-9F for submit@debbugs.gnu.org; Thu, 04 Mar 2021 10:13:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHpfb-0007cT-HJ for 46859@debbugs.gnu.org; Thu, 04 Mar 2021 10:13:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33728) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHpfW-0001tC-6t; Thu, 04 Mar 2021 10:13:38 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2448 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lHpfV-0004Uj-A4; Thu, 04 Mar 2021 10:13:37 -0500 In-Reply-To: <9cff0f88942d4103c685@heytings.org> (message from Gregory Heytings on Thu, 04 Mar 2021 14:39:23 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201402 Archived-At: > Date: Thu, 04 Mar 2021 14:39:23 +0000 > From: Gregory Heytings > cc: 46859@debbugs.gnu.org > > But you provide the solution: when an xref is followed, the file is opened > in a buffer, at which point buffer-file-coding-system is set. So it seems > that it suffices to do (goto-char (filepos-to-bufferpos > (get-byte-position))). Yes. But it can be slow. > I just did a filepos-to-bufferpos for one of the last bytes of a 6 MB > Latin-1 file, and it took only ~2 ms. Which value of QUALITY did you use? Also, what happens with multibyte encodings that are not UTF-8, like iso-2022, for example?