From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Tue, 09 Mar 2021 20:31:39 +0200 Message-ID: <83mtvcp4ac.fsf@gnu.org> References: <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <8335x6u9o4.fsf@gnu.org> <83zgzesrku.fsf@gnu.org> <83tupms4mp.fsf@gnu.org> <83eegpspjk.fsf@gnu.org> <83r1kpr03h.fsf@gnu.org> <83mtvdqt53.fsf@gnu.org> <83blbsqyea.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com, pipcet@gmail.com To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 21:14:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJikM-0009bR-JZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 21:14:26 +0100 Original-Received: from localhost ([::1]:38168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJikL-0002Yx-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 15:14:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJh9G-0004XK-2h for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 13:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJh9F-00033v-Qf for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 13:32:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJh9F-0008HO-NG for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 13:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161531471131809 (code B ref 46256); Tue, 09 Mar 2021 18:32:01 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 9 Mar 2021 18:31:51 +0000 Original-Received: from localhost ([127.0.0.1]:47922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJh95-0008Gy-Ea for submit@debbugs.gnu.org; Tue, 09 Mar 2021 13:31:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJh93-0008Gk-Rv for 46256@debbugs.gnu.org; Tue, 09 Mar 2021 13:31:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43143) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJh8y-0002wt-Cf; Tue, 09 Mar 2021 13:31:44 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4212 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lJh8x-0004WK-QT; Tue, 09 Mar 2021 13:31:44 -0500 In-Reply-To: (message from Andrea Corallo on Tue, 09 Mar 2021 14:55:40 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201937 Archived-At: > From: Andrea Corallo > Cc: pipcet@gmail.com, 46256@debbugs.gnu.org, andrewjmoreton@gmail.com > Date: Tue, 09 Mar 2021 14:55:40 +0000 > > cc-*.el files for instance have more than one direct call to load. IIRC > one of the analyzed cases was cc-mode related (certanly one I observed). > > >> > What are the reasons for unloading a .eln file which was once loaded > >> > into a session? > >> > >> All the functions defined in it are not anymore reachable (read all > >> symbols functions are makunbound or defined to some other function). > > > > That means someone did unload-feature, right? > > Also loading for example a new version freshly compiled of the same file > should present the same scenario. I see a problem in this area. Consider this code in native-elisp-load: if (!NILP (Fgethash (filename, all_loaded_comp_units_h, Qnil)) && !file_in_eln_sys_dir (filename) && !NILP (Ffile_writable_p (filename))) { /* If in this session there was ever a file loaded with this name, rename it before loading, to make sure we always get a new handle! */ Lisp_Object tmp_filename = Fmake_temp_file_internal (filename, Qnil, build_string (".eln.tmp"), Qnil); if (NILP (Ffile_writable_p (tmp_filename))) comp_u->handle = dynlib_open (SSDATA (encoded_filename)); else { Frename_file (filename, tmp_filename, Qt); comp_u->handle = dynlib_open (SSDATA (ENCODE_FILE (tmp_filename))); Frename_file (tmp_filename, filename, Qnil); } The last 'else' branch momentarily renames the .eln file, then loads it under the modified name, with the assumption that this would force dynlib_open to produce a new handle. But in the case that the same .eln file is loaded more than once, i.e. the .eln file was not modified since the previous load, dynlib_open returns the same handle regardless of the file name, at least on MS-Windows. (Does this work as intended on GNU/Linux?) The problem with returning the same handle is that the refcount of the handle is incremented, which means unload-feature will be unable to unload the library. Is this renaming dance for the case that the .eln file was updated since the last load, or do we need it even if it wasn't updated? If the former, then I guess we could dynlib_close the handle immediately if we discover that it's identical to the one we had from the previous load.