unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
@ 2021-05-24 16:02 Bob Floyd
  2021-05-24 16:33 ` Eli Zaretskii
  2021-06-06 11:01 ` Eli Zaretskii
  0 siblings, 2 replies; 8+ messages in thread
From: Bob Floyd @ 2021-05-24 16:02 UTC (permalink / raw)
  To: 48628


[-- Attachment #1.1: Type: text/plain, Size: 5526 bytes --]

Hi,

 

Attached are 3 files, 'f1.cpp', 'f2.cpp', and 'TAGS'.

 

I'm using the development 28.0.50 version on Windows.

 

Start emacs and:

 

1. C-x 2 (split-window-below)

2. C-x C-f (find-file) "f1.cpp" in the upper window

3. C-x C-f (find-file) "f2.cpp" in the lower window

4. left-mouse click in the upper window top left (location of the search
start)

5. <f3> (tags-search) the string "_cu" using the attached TAGS file

   Tags search (regexp): _cu

6. M-, (fileloop-continue) until reaching "All files processed"

   The matches are on lines:

   f1.cpp: 7, 25, 65, 104, 121

   f2.cpp: 7, 25, 65, 104, 121

   (both f1 and f2 have identical contents).

7. In the upper window, switch to buffer f1.cpp and go to line 53:

8. mark line 53 and move down to line 72, then delete the selection:

   You're deleting this:

   case ECall::DPI::_pow_:

      {

                IT::IAcc                 _one ( R()->c1.CastTo( _ty ) );

                IT::IAcc                 _zero( R()->c0.CastTo( _ty ) );

                IT::IAcc                 _condBase

                ( _theFunction.Arg(0) .EqEq( IT::FlagsOfIKind(), _zero ) );

                IT::IAcc                 _condExp

                ( _theFunction.Arg(1) .LT( IT::FlagsOfIKind(), _zero ) );

 

                // Specialize to capture `0 ** 0` and return 1.

 

                IT::IfHlpr              _testSpcl

                ( _cu, _condBase .AndAnd (IT::FlagsOfIKind(), _condExp),
IT::List() );

 

                _testSpcl.True() << _one.Return();

 

                _body << _testSpcl;

 

                break;

      }

9. M-< (beginning-of-buffer) in the upper window ("f1.cpp")

10. <f3> (tags-search) the string "_cu" 

   Tags search (regexp): _cu

11. M-, (fileloop-continue) until reaching "All files processed"

   The matches are on lines:

   7, 25, 85, 102, 115, 121

   NOTE 115 is wrong, it is this line that does not contain "_cu"

#     ifdef C_FILE_GENERATOR

   NOTE only 1 of the "_cu"s was deleted so instead of 10 occurrences there

   should be 9 BUT it only found 6.

 

 

 

In GNU Emacs 28.0.50 (build 1, x86_64-w64-mingw32)

of 2021-01-15 built on CIRROCUMULUS

Repository revision: f45be48ddbde00610e1e08fca6590dcf24a4e1b5

Repository branch: master

Windowing system distributor 'Microsoft Corp.', version 10.0.19042

System Description: Microsoft Windows 10 Enterprise (v10.0.2009.19042.985)

 

Configured using:

'configure --without-dbus --without-compress-install -C 'CFLAGS=-O2

-static -g3' PKG_CONFIG_PATH=/mingw64/lib/pkgconfig'

 

Configured features:

ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY

W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM

ZLIB

 

Important settings:

  value of $LANG: ENU

  locale-coding-system: cp1252

 

Major mode: Fundamental

 

Minor modes in effect:

  shell-dirtrack-mode: t

  show-paren-mode: t

  tooltip-mode: t

  global-eldoc-mode: t

  electric-indent-mode: t

  mouse-wheel-mode: t

  menu-bar-mode: t

  file-name-shadow-mode: t

  global-font-lock-mode: t

  font-lock-mode: t

  blink-cursor-mode: t

  auto-composition-mode: t

  auto-encryption-mode: t

  auto-compression-mode: t

  line-number-mode: t

  transient-mark-mode: t

 

Load-path shadows:

None found.

 

Features:

(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs

rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs

text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231

mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums

mm-util mail-prsvr mail-utils misearch multi-isearch two-column

help-mode thingatpt etags fileloop generator xref project time-date

pcmpl-unix web-mode advice derived edmacro kmacro shell pcomplete comint

ansi-color ring printing ps-print ps-print-loaddefs ps-def lpr paren

cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine

cc-vars cc-defs finder-inf tex-site info package easymenu browse-url url

url-proxy url-privacy url-expand url-methods url-history url-cookie

url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq

eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map

url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib

iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks

lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win

w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe

tabulated-list replace newcomment text-mode elisp-mode lisp-mode

prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer

select scroll-bar mouse jit-lock font-lock syntax facemenu font-core

term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang

misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms

cp51932 hebrew greek romanian slovak czech european ethiopic indian

cyrillic chinese composite charscript charprop case-table epa-hook

jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button

loaddefs faces cus-face macroexp files window text-properties overlay

sha1 md5 base64 format env code-pages mule custom widget

hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty

make-network-process emacs)

 

Memory information:

((conses 16 192149 7744)

(symbols 48 14547 1)

(strings 32 50102 1978)

(string-bytes 1 1608447)

(vectors 16 21762)

(vector-slots 8 294115 19624)

(floats 8 263 356)

(intervals 56 3062 0)

(buffers 984 18))


[-- Attachment #1.2: Type: text/html, Size: 13372 bytes --]

[-- Attachment #2: f1.cpp --]
[-- Type: text/plain, Size: 3863 bytes --]

namespace PT
{
  ConstFP::Fcn
  ConstFP::PrecisionsOfOneFcn::
  CreateFcn( TyAcc const& _ty ) const
  {
    CompilationUnit&	_cu              ( G->CU() );
    TpSgmtCntnr		_pSC             ( new SgmtCntnrSC );
    IObj<DHscope>	_iDolRootScope   ( G->GetHierarchy().DolRootScope() );
    ILexObj<LexScope>	_iLexDolRootScope( _iDolRootScope->GetLexScope() );

    typedef TypeList<EFormal>::Result			TMods;

    std::vector<ITracks>	_myArgs( nArgs() );

    VariableSymbol	_arg( TMods(), _ty );

    for ( int _i( 0 ); _i < nArgs(); ++_i )
    {
      std::stringstream	_nmArg;

      _nmArg << "_arg" << _i;

      ITracks		_iArg
      ( _iDolRootScope.TrackFactory<VariableSymbol>(_nmArg.str(),_arg,(*_pSC),_cu) );

      _myArgs[ _i ] = _iArg;
    }

    std::stringstream	_nmFcn;

    _nmFcn << "!" << ECall::DPI(myDpiId).Id();

    switch ( myDpiId )
    {
    case ECall::DPI::_pow_:
      _nmFcn << "Wrapr";
    default:
      break;
    }

    _nmFcn << R()->GetNextDLLid();

    IT::FcnDclHlpr _theFunction( (*_pSC), _ty, _nmFcn, IT::TFcn::_dllExport_ );

    for ( int _i( 0 ); _i < nArgs(); ++_i )
      _theFunction    << IT::IAcc( Expr( _myArgs[ _i ], NuVloc() ) );

    IT::List	_body;

    switch ( myDpiId )
    {
    case ECall::DPI::_pow_:
      {
	IT::IAcc		_one ( R()->c1.CastTo( _ty ) );
	IT::IAcc		_zero( R()->c0.CastTo( _ty ) );
	IT::IAcc		_condBase
	( _theFunction.Arg(0) .EqEq( IT::FlagsOfIKind(), _zero ) );
	IT::IAcc		_condExp
	( _theFunction.Arg(1) .LT( IT::FlagsOfIKind(), _zero ) );

	// Specialize to capture `0 ** 0` and return 1.

	IT::IfHlpr	_testSpcl
	( _cu, _condBase .AndAnd (IT::FlagsOfIKind(), _condExp), IT::List() );

	_testSpcl.True() << _one.Return();

	_body << _testSpcl;

	break;
      }
    default:
      break;
    }

    IT::List		_itActualList;

    for ( int _i( 0 ); _i < nArgs(); ++_i )
      _itActualList << IT::IAcc( Expr( _myArgs[ _i ], NuVloc() ) ).FcnArg();

    IT::IAcc	_theLibmCall( _itActualList.Head()
    .CallDpi( _ty, DpiProto(), myDpiId, IT::FlagsOfIKind() ) );

    _body << _theLibmCall.Return();

    _theFunction << _body.Head();

    typedef SgmtCntnr::IBrndToSmblsWthLval	IBrndToSmblsWthLval;
    typedef SgmtCntnr::BtoSwLkey		BtoSwLkey;

    TpSignature	_noSig    ( new Signature );
    TBranding*	_branding ( new TBranding );
    TIBranding	_iBranding
    ( _branding->Insert( _iLexDolRootScope,Brands() ).first );
    TpBrand	_pBrand   ( new Brand( _iBranding ) );
    RefPtr<Brands>_oneBrand( new Brands( _noSig, _pBrand ) );
    IBrands	_iBrands (IPair<TBrands::TIterator>((*_oneBrand).begin(),true));
    IBrndToSmblsWthLval _iBtoWsl( (*_pSC)->Get( BtoSwLkey( _iBrands ) ) );
    OneGeste	_theGeste
    ( R()->terminusStmt, _iLexDolRootScope, _iDolRootScope, DLLobject() );

    IT::TpLlVmGenerator	_pLlVm
    ( _cu.LlVmGeneratorFactory( true/*isCommonToAllCUs*/ ) );

    _theGeste.SetClosure( _theFunction );

    _pSC->AllocLvalToGeste( _iBrands, _theGeste );

    _pLlVm->AtFunction( (*_pSC), _iBrands, _iBtoWsl, _theGeste );


    switch ( myDpiId )
    {
#     ifdef C_FILE_GENERATOR
    case ECall::DPI::_pow_:
      _pSC->AddRef();
      _pBrand->AddRef();
      _oneBrand->AddRef();
      _noSig->AddRef();	
      _cu.GetCfileGenerator()->AtFunction( *_pSC, _iBrands, _theGeste );
      break;
#     endif C_FILE_GENERATOR
    default:
      delete _branding;
      break;
    }

    TyFloat const&	_tyFloat( *(TyFloat const*)_ty );
    Fcn			_rslt;

    if ( _tyFloat.GetnBits() <= TyFloat::_IEEEdouble_
    ||   ConstFP::LongDoubleIs128Bits() )
    {
      try {
	_rslt = Fcn( _ty, _pLlVm->JIT(), _nmFcn.str() );
      } catch ( Message& _msg ) {
	_rslt = LowerPrecision( _tyFloat, _msg );
      }
    }

    return _rslt;
  }
}

[-- Attachment #3: f2.cpp --]
[-- Type: text/plain, Size: 3863 bytes --]

namespace PT
{
  ConstFP::Fcn
  ConstFP::PrecisionsOfOneFcn::
  CreateFcn( TyAcc const& _ty ) const
  {
    CompilationUnit&	_cu              ( G->CU() );
    TpSgmtCntnr		_pSC             ( new SgmtCntnrSC );
    IObj<DHscope>	_iDolRootScope   ( G->GetHierarchy().DolRootScope() );
    ILexObj<LexScope>	_iLexDolRootScope( _iDolRootScope->GetLexScope() );

    typedef TypeList<EFormal>::Result			TMods;

    std::vector<ITracks>	_myArgs( nArgs() );

    VariableSymbol	_arg( TMods(), _ty );

    for ( int _i( 0 ); _i < nArgs(); ++_i )
    {
      std::stringstream	_nmArg;

      _nmArg << "_arg" << _i;

      ITracks		_iArg
      ( _iDolRootScope.TrackFactory<VariableSymbol>(_nmArg.str(),_arg,(*_pSC),_cu) );

      _myArgs[ _i ] = _iArg;
    }

    std::stringstream	_nmFcn;

    _nmFcn << "!" << ECall::DPI(myDpiId).Id();

    switch ( myDpiId )
    {
    case ECall::DPI::_pow_:
      _nmFcn << "Wrapr";
    default:
      break;
    }

    _nmFcn << R()->GetNextDLLid();

    IT::FcnDclHlpr _theFunction( (*_pSC), _ty, _nmFcn, IT::TFcn::_dllExport_ );

    for ( int _i( 0 ); _i < nArgs(); ++_i )
      _theFunction    << IT::IAcc( Expr( _myArgs[ _i ], NuVloc() ) );

    IT::List	_body;

    switch ( myDpiId )
    {
    case ECall::DPI::_pow_:
      {
	IT::IAcc		_one ( R()->c1.CastTo( _ty ) );
	IT::IAcc		_zero( R()->c0.CastTo( _ty ) );
	IT::IAcc		_condBase
	( _theFunction.Arg(0) .EqEq( IT::FlagsOfIKind(), _zero ) );
	IT::IAcc		_condExp
	( _theFunction.Arg(1) .LT( IT::FlagsOfIKind(), _zero ) );

	// Specialize to capture `0 ** 0` and return 1.

	IT::IfHlpr	_testSpcl
	( _cu, _condBase .AndAnd (IT::FlagsOfIKind(), _condExp), IT::List() );

	_testSpcl.True() << _one.Return();

	_body << _testSpcl;

	break;
      }
    default:
      break;
    }

    IT::List		_itActualList;

    for ( int _i( 0 ); _i < nArgs(); ++_i )
      _itActualList << IT::IAcc( Expr( _myArgs[ _i ], NuVloc() ) ).FcnArg();

    IT::IAcc	_theLibmCall( _itActualList.Head()
    .CallDpi( _ty, DpiProto(), myDpiId, IT::FlagsOfIKind() ) );

    _body << _theLibmCall.Return();

    _theFunction << _body.Head();

    typedef SgmtCntnr::IBrndToSmblsWthLval	IBrndToSmblsWthLval;
    typedef SgmtCntnr::BtoSwLkey		BtoSwLkey;

    TpSignature	_noSig    ( new Signature );
    TBranding*	_branding ( new TBranding );
    TIBranding	_iBranding
    ( _branding->Insert( _iLexDolRootScope,Brands() ).first );
    TpBrand	_pBrand   ( new Brand( _iBranding ) );
    RefPtr<Brands>_oneBrand( new Brands( _noSig, _pBrand ) );
    IBrands	_iBrands (IPair<TBrands::TIterator>((*_oneBrand).begin(),true));
    IBrndToSmblsWthLval _iBtoWsl( (*_pSC)->Get( BtoSwLkey( _iBrands ) ) );
    OneGeste	_theGeste
    ( R()->terminusStmt, _iLexDolRootScope, _iDolRootScope, DLLobject() );

    IT::TpLlVmGenerator	_pLlVm
    ( _cu.LlVmGeneratorFactory( true/*isCommonToAllCUs*/ ) );

    _theGeste.SetClosure( _theFunction );

    _pSC->AllocLvalToGeste( _iBrands, _theGeste );

    _pLlVm->AtFunction( (*_pSC), _iBrands, _iBtoWsl, _theGeste );


    switch ( myDpiId )
    {
#     ifdef C_FILE_GENERATOR
    case ECall::DPI::_pow_:
      _pSC->AddRef();
      _pBrand->AddRef();
      _oneBrand->AddRef();
      _noSig->AddRef();	
      _cu.GetCfileGenerator()->AtFunction( *_pSC, _iBrands, _theGeste );
      break;
#     endif C_FILE_GENERATOR
    default:
      delete _branding;
      break;
    }

    TyFloat const&	_tyFloat( *(TyFloat const*)_ty );
    Fcn			_rslt;

    if ( _tyFloat.GetnBits() <= TyFloat::_IEEEdouble_
    ||   ConstFP::LongDoubleIs128Bits() )
    {
      try {
	_rslt = Fcn( _ty, _pLlVm->JIT(), _nmFcn.str() );
      } catch ( Message& _msg ) {
	_rslt = LowerPrecision( _tyFloat, _msg );
      }
    }

    return _rslt;
  }
}

[-- Attachment #4: TAGS --]
[-- Type: application/octet-stream, Size: 466 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-05-24 16:02 bug#48628: tags-search fails to find all occurences and finds one that it shouldn't Bob Floyd
@ 2021-05-24 16:33 ` Eli Zaretskii
  2021-05-24 16:48   ` Bob Floyd
  2021-06-06 11:01 ` Eli Zaretskii
  1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2021-05-24 16:33 UTC (permalink / raw)
  To: Bob Floyd; +Cc: 48628

> From: "Bob Floyd" <bobfloyd@comcast.net>
> Date: Mon, 24 May 2021 09:02:54 -0700
> 
> 1. C-x 2 (split-window-below)
> 
> 2. C-x C-f (find-file) "f1.cpp" in the upper window
> 
> 3. C-x C-f (find-file) "f2.cpp" in the lower window
> 
> 4. left-mouse click in the upper window top left (location of the search start)
> 
> 5. <f3> (tags-search) the string "_cu" using the attached TAGS file
> 
>    Tags search (regexp): _cu
> 
> 6. M-, (fileloop-continue) until reaching "All files processed"
> 
>    The matches are on lines:
> 
>    f1.cpp: 7, 25, 65, 104, 121
> 
>    f2.cpp: 7, 25, 65, 104, 121
> 
>    (both f1 and f2 have identical contents).
> 
> 7. In the upper window, switch to buffer f1.cpp and go to line 53:
> 
> 8. mark line 53 and move down to line 72, then delete the selection:

When you change the file, and you want exact results, you need to
re-run etags, right?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-05-24 16:33 ` Eli Zaretskii
@ 2021-05-24 16:48   ` Bob Floyd
  0 siblings, 0 replies; 8+ messages in thread
From: Bob Floyd @ 2021-05-24 16:48 UTC (permalink / raw)
  To: 'Eli Zaretskii'; +Cc: 48628

No, not when using tags-search, tags-query-replace. They use the tags file
only to identify what files to search in. However, you are correct when
using things like M-. (xref-find-definitions) when the definition has been
moved too far from its original location.

The failure of tags-search (and the same sort of failure happens with
tags-query-replace) is new to the 28 versions as best I can determine.

-----Original Message-----
From: Eli Zaretskii [mailto:eliz@gnu.org] 
Sent: Monday, May 24, 2021 9:34 AM
To: Bob Floyd
Cc: 48628@debbugs.gnu.org
Subject: Re: bug#48628: tags-search fails to find all occurences and finds
one that it shouldn't

> From: "Bob Floyd" <bobfloyd@comcast.net>
> Date: Mon, 24 May 2021 09:02:54 -0700
> 
> 1. C-x 2 (split-window-below)
> 
> 2. C-x C-f (find-file) "f1.cpp" in the upper window
> 
> 3. C-x C-f (find-file) "f2.cpp" in the lower window
> 
> 4. left-mouse click in the upper window top left (location of the search
start)
> 
> 5. <f3> (tags-search) the string "_cu" using the attached TAGS file
> 
>    Tags search (regexp): _cu
> 
> 6. M-, (fileloop-continue) until reaching "All files processed"
> 
>    The matches are on lines:
> 
>    f1.cpp: 7, 25, 65, 104, 121
> 
>    f2.cpp: 7, 25, 65, 104, 121
> 
>    (both f1 and f2 have identical contents).
> 
> 7. In the upper window, switch to buffer f1.cpp and go to line 53:
> 
> 8. mark line 53 and move down to line 72, then delete the selection:

When you change the file, and you want exact results, you need to
re-run etags, right?






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-05-24 16:02 bug#48628: tags-search fails to find all occurences and finds one that it shouldn't Bob Floyd
  2021-05-24 16:33 ` Eli Zaretskii
@ 2021-06-06 11:01 ` Eli Zaretskii
  2021-06-06 12:31   ` Eli Zaretskii
  2021-06-06 18:03   ` Bob Floyd
  1 sibling, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2021-06-06 11:01 UTC (permalink / raw)
  To: Bob Floyd; +Cc: 48628

> From: "Bob Floyd" <bobfloyd@comcast.net>
> Date: Mon, 24 May 2021 09:02:54 -0700
> 
> 11. M-, (fileloop-continue) until reaching "All files processed"
> 
>    The matches are on lines:
> 
>    7, 25, 85, 102, 115, 121
> 
>    NOTE 115 is wrong, it is this line that does not contain "_cu"

With today's master branch, I'm unable to reproduce the problem: I
don't get the false match on line 115.

Are you still able to reproduce with the latest master branch?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-06-06 11:01 ` Eli Zaretskii
@ 2021-06-06 12:31   ` Eli Zaretskii
  2021-06-06 18:05     ` Bob Floyd
  2021-06-06 18:03   ` Bob Floyd
  1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2021-06-06 12:31 UTC (permalink / raw)
  To: bobfloyd; +Cc: 48628

> Date: Sun, 06 Jun 2021 14:01:34 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 48628@debbugs.gnu.org
> 
> > From: "Bob Floyd" <bobfloyd@comcast.net>
> > Date: Mon, 24 May 2021 09:02:54 -0700
> > 
> > 11. M-, (fileloop-continue) until reaching "All files processed"
> > 
> >    The matches are on lines:
> > 
> >    7, 25, 85, 102, 115, 121
> > 
> >    NOTE 115 is wrong, it is this line that does not contain "_cu"
> 
> With today's master branch, I'm unable to reproduce the problem: I
> don't get the false match on line 115.

However, I did spot a problem in these commands: a new tags-search
will not always start searching in each buffer from the beginning,
sometimes it will restart from the last place point was displayed for
this buffer.  So I fixed that problem on the master branch now.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-06-06 11:01 ` Eli Zaretskii
  2021-06-06 12:31   ` Eli Zaretskii
@ 2021-06-06 18:03   ` Bob Floyd
  1 sibling, 0 replies; 8+ messages in thread
From: Bob Floyd @ 2021-06-06 18:03 UTC (permalink / raw)
  To: 'Eli Zaretskii'; +Cc: 48628

I'm using the (as far as I know) the latest already-compiled-for-windows
(/gnu/emacs/pretest/windows/emacs-28) - mostly because I don't wish the
hassle of figuring out the directions for compiling the master branch -
since long ago windows was 2nd class to the unix's doing so wasn't easy.
Perhaps it has improved?

Having said that, my test cases for reproducing this (#48107 and now #48628)
either aren't sufficient to be reproducible, or indeed were fixed. In both
these I'd say the only choice is to work with the master branch, and thus if
I can create a test case there is nothing more recent to say it would be
fixed in.

Sorry for the long-windedness, but do you have a URL for how to download and
compile the master branch for windows?

-----Original Message-----
From: Eli Zaretskii [mailto:eliz@gnu.org] 
Sent: Sunday, June 6, 2021 4:02 AM
To: Bob Floyd
Cc: 48628@debbugs.gnu.org
Subject: Re: bug#48628: tags-search fails to find all occurences and finds
one that it shouldn't

> From: "Bob Floyd" <bobfloyd@comcast.net>
> Date: Mon, 24 May 2021 09:02:54 -0700
> 
> 11. M-, (fileloop-continue) until reaching "All files processed"
> 
>    The matches are on lines:
> 
>    7, 25, 85, 102, 115, 121
> 
>    NOTE 115 is wrong, it is this line that does not contain "_cu"

With today's master branch, I'm unable to reproduce the problem: I
don't get the false match on line 115.

Are you still able to reproduce with the latest master branch?






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-06-06 12:31   ` Eli Zaretskii
@ 2021-06-06 18:05     ` Bob Floyd
  2021-06-06 18:10       ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Bob Floyd @ 2021-06-06 18:05 UTC (permalink / raw)
  To: 'Eli Zaretskii'; +Cc: 48628

Super! Do you have a URL explaining how to download and compile the master
branch for Windows?

-----Original Message-----
From: Eli Zaretskii [mailto:eliz@gnu.org] 
Sent: Sunday, June 6, 2021 5:32 AM
To: bobfloyd@comcast.net
Cc: 48628@debbugs.gnu.org
Subject: Re: bug#48628: tags-search fails to find all occurences and finds
one that it shouldn't

> Date: Sun, 06 Jun 2021 14:01:34 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 48628@debbugs.gnu.org
> 
> > From: "Bob Floyd" <bobfloyd@comcast.net>
> > Date: Mon, 24 May 2021 09:02:54 -0700
> > 
> > 11. M-, (fileloop-continue) until reaching "All files processed"
> > 
> >    The matches are on lines:
> > 
> >    7, 25, 85, 102, 115, 121
> > 
> >    NOTE 115 is wrong, it is this line that does not contain "_cu"
> 
> With today's master branch, I'm unable to reproduce the problem: I
> don't get the false match on line 115.

However, I did spot a problem in these commands: a new tags-search
will not always start searching in each buffer from the beginning,
sometimes it will restart from the last place point was displayed for
this buffer.  So I fixed that problem on the master branch now.






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#48628: tags-search fails to find all occurences and finds one that it shouldn't
  2021-06-06 18:05     ` Bob Floyd
@ 2021-06-06 18:10       ` Eli Zaretskii
  0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2021-06-06 18:10 UTC (permalink / raw)
  To: Bob Floyd; +Cc: 48628

> From: "Bob Floyd" <bobfloyd@comcast.net>
> Cc: <48628@debbugs.gnu.org>
> Date: Sun, 6 Jun 2021 11:05:41 -0700
> 
> Super! Do you have a URL explaining how to download and compile the master
> branch for Windows?

https://git.savannah.gnu.org/cgit/emacs.git/tree/nt/INSTALL.W64





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-06-06 18:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 16:02 bug#48628: tags-search fails to find all occurences and finds one that it shouldn't Bob Floyd
2021-05-24 16:33 ` Eli Zaretskii
2021-05-24 16:48   ` Bob Floyd
2021-06-06 11:01 ` Eli Zaretskii
2021-06-06 12:31   ` Eli Zaretskii
2021-06-06 18:05     ` Bob Floyd
2021-06-06 18:10       ` Eli Zaretskii
2021-06-06 18:03   ` Bob Floyd

unofficial mirror of bug-gnu-emacs@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/emacs-bugs/0 emacs-bugs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 emacs-bugs emacs-bugs/ https://yhetil.org/emacs-bugs \
		bug-gnu-emacs@gnu.org
	public-inbox-index emacs-bugs

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.bugs
	nntp://news.gmane.io/gmane.emacs.bugs


code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git