bug#49466: 28.0.50; C-<mouse-2> is undefined

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Juri Linkov]

The Info manual says in (info "(emacs) Menu Mouse Clicks")

  ‘C-mouse-2’
       This menu contains entries for examining faces and other text
       properties, and well as for setting them (the latter is mainly
       useful when editing enriched text; *note Enriched Text::).

But clicking C-mouse-2 signals the error:

  C-<mouse-2> is undefined

The above Info node has a link to the "Enriched Text" node
where (info "(emacs) Editing Format Info") says:

  The easiest way to alter properties is with the ‘Text Properties’ menu.
  You can get to this menu from the ‘Edit’ menu in the menu bar (*note
  Menu Bar::), or with ‘C-mouse-2’ (*note Menu Mouse Clicks::).

However, ‘C-mouse-2’ fails even in enriched-mode,
e.g. after visiting etc/enriched.txt.

Also the documented ‘Text Properties’ menu
is not displayed in enriched-mode.

PS: There is also this comment in lisp/mouse.el,
maybe it should be removed:

  ;; C-down-mouse-2 is bound in facemenu.el.

bug#49466: [External] : bug#49466: 28.0.50; C-<mouse-2> is undefined

[Drew Adams]

> The Info manual says in (info "(emacs) Menu Mouse Clicks")
>   ‘C-mouse-2’
>        This menu contains entries for examining faces and other text
>        properties, and well as for setting them (the latter is mainly
>        useful when editing enriched text; *note Enriched Text::).
> 
> But clicking C-mouse-2 signals the error:
>   C-<mouse-2> is undefined
> 
> The above Info node has a link to the "Enriched Text" node
> where (info "(emacs) Editing Format Info") says:
> 
>   The easiest way to alter properties is with the ‘Text Properties’ menu.
>   You can get to this menu from the ‘Edit’ menu in the menu bar (*note
>   Menu Bar::), or with ‘C-mouse-2’ (*note Menu Mouse Clicks::).
> 
> However, ‘C-mouse-2’ fails even in enriched-mode,
> e.g. after visiting etc/enriched.txt.
> 
> Also the documented ‘Text Properties’ menu
> is not displayed in enriched-mode.
> 
> PS: There is also this comment in lisp/mouse.el,
> maybe it should be removed:
>   ;; C-down-mouse-2 is bound in facemenu.el.

More fallout from removing facemenu load by default,
I guess.  (Why was that done, again?)

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Thu, 08 Jul 2021 20:36:22 +0300
> 
> The Info manual says in (info "(emacs) Menu Mouse Clicks")
> 
>   ‘C-mouse-2’
>        This menu contains entries for examining faces and other text
>        properties, and well as for setting them (the latter is mainly
>        useful when editing enriched text; *note Enriched Text::).
> 
> But clicking C-mouse-2 signals the error:
> 
>   C-<mouse-2> is undefined
> 
> The above Info node has a link to the "Enriched Text" node
> where (info "(emacs) Editing Format Info") says:
> 
>   The easiest way to alter properties is with the ‘Text Properties’ menu.
>   You can get to this menu from the ‘Edit’ menu in the menu bar (*note
>   Menu Bar::), or with ‘C-mouse-2’ (*note Menu Mouse Clicks::).
> 
> However, ‘C-mouse-2’ fails even in enriched-mode,
> e.g. after visiting etc/enriched.txt.
> 
> Also the documented ‘Text Properties’ menu
> is not displayed in enriched-mode.
> 
> PS: There is also this comment in lisp/mouse.el,
> maybe it should be removed:
> 
>   ;; C-down-mouse-2 is bound in facemenu.el.

That's because that binding was removed as part of butchering
facemenu.el in Emacs 28.

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Eli Zaretskii]

> Date: Thu, 08 Jul 2021 22:22:04 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 49466@debbugs.gnu.org
> 
> > From: Juri Linkov <juri@linkov.net>
> > Date: Thu, 08 Jul 2021 20:36:22 +0300
> > 
> > The Info manual says in (info "(emacs) Menu Mouse Clicks")
> > 
> >   ‘C-mouse-2’
> >        This menu contains entries for examining faces and other text
> >        properties, and well as for setting them (the latter is mainly
> >        useful when editing enriched text; *note Enriched Text::).
> > 
> > But clicking C-mouse-2 signals the error:
> > 
> >   C-<mouse-2> is undefined
> 
> That's because that binding was removed as part of butchering
> facemenu.el in Emacs 28.

I resurrected the C-mouse-2 binding, but it still needs facemenu to be
loaded before it will work.

Stefan, is there some way to make this auto-loaded?  That is, whenever
the user presses C-mouse-2, automatically load facemenu and show the
drop-down menu in facemenu-menu?  I tried autoloading the
facemenu-menu keymap like ispell and pcvs do, but that doesn't seem to
work, in the sense that pressing C-mouse-2 complains that the binding
is not a command.

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Stefan, is there some way to make this auto-loaded?  That is, whenever
> the user presses C-mouse-2, automatically load facemenu and show the
> drop-down menu in facemenu-menu?  I tried autoloading the
> facemenu-menu keymap like ispell and pcvs do, but that doesn't seem to
> work, in the sense that pressing C-mouse-2 complains that the binding
> is not a command.

The patch below works for me, should I push it?


        Stefan "who hasn't followed this discussion"


diff --git a/lisp/facemenu.el b/lisp/facemenu.el
index 9d75302a97..8631be917a 100644
--- a/lisp/facemenu.el
+++ b/lisp/facemenu.el
@@ -244,6 +244,8 @@ facemenu-menu
   (define-key map [fc] (cons "Face" 'facemenu-face-menu)))
 (defalias 'facemenu-menu facemenu-menu)
 
+;;;###autoload (autoload 'facemenu-menu "facemenu" nil nil 'keymap)
+;;;###autoload
 (define-key global-map [C-down-mouse-2] 'facemenu-menu)
 
 (easy-menu-add-item

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: juri@linkov.net,  49466@debbugs.gnu.org
> Date: Fri, 09 Jul 2021 09:39:14 -0400
> 
> > Stefan, is there some way to make this auto-loaded?  That is, whenever
> > the user presses C-mouse-2, automatically load facemenu and show the
> > drop-down menu in facemenu-menu?  I tried autoloading the
> > facemenu-menu keymap like ispell and pcvs do, but that doesn't seem to
> > work, in the sense that pressing C-mouse-2 complains that the binding
> > is not a command.
> 
> The patch below works for me, should I push it?

Yes, please.

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> The patch below works for me, should I push it?
> Yes, please.

Done,


        Stefan

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: juri@linkov.net,  49466@debbugs.gnu.org
> Date: Fri, 09 Jul 2021 15:53:59 -0400
> 
> >> The patch below works for me, should I push it?
> > Yes, please.
> 
> Done,

Thanks.

Juri, is there anything else to be done here, or can we close this
bug?

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Juri Linkov]

>> >> The patch below works for me, should I push it?
>> > Yes, please.
>> 
>> Done,
>
> Thanks.
>
> Juri, is there anything else to be done here, or can we close this
> bug?

What remains to do is this:

The documentation of the Enriched Mode in
(info "(emacs) Editing Format Info") says:

  The easiest way to alter properties is with the ‘Text Properties’ menu.
  You can get to this menu from the ‘Edit’ menu in the menu bar

But the documented ‘Text Properties’ menu is not displayed in enriched-mode.

This can be fixed by just requiring facemenu in enriched.el:

diff --git a/lisp/textmodes/enriched.el b/lisp/textmodes/enriched.el
index ba8fac81f2..877658a5a5 100644
--- a/lisp/textmodes/enriched.el
+++ b/lisp/textmodes/enriched.el
@@ -38,7 +38,7 @@
 
 ;;; Code:
 
-(provide 'enriched)
+(require 'facemenu)
 
 ;;;
 ;;; Variables controlling the display
@@ -538,4 +538,6 @@ enriched-decode-display-prop
         (list start end 'display prop)
       (list start end 'display (list 'disable-eval prop)))))
 
+(provide 'enriched)
+
 ;;; enriched.el ends here

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  49466@debbugs.gnu.org
> Date: Sun, 11 Jul 2021 03:18:42 +0300
> 
> What remains to do is this:
> 
> The documentation of the Enriched Mode in
> (info "(emacs) Editing Format Info") says:
> 
>   The easiest way to alter properties is with the ‘Text Properties’ menu.
>   You can get to this menu from the ‘Edit’ menu in the menu bar
> 
> But the documented ‘Text Properties’ menu is not displayed in enriched-mode.
> 
> This can be fixed by just requiring facemenu in enriched.el:

Fine with me, please install.

Thanks.

bug#49466: 28.0.50; C-<mouse-2> is undefined

[Juri Linkov]

tags 49466 fixed
close 49466 28.0.50
quit

>> What remains to do is this:
>> 
>> The documentation of the Enriched Mode in
>> (info "(emacs) Editing Format Info") says:
>> 
>>   The easiest way to alter properties is with the ‘Text Properties’ menu.
>>   You can get to this menu from the ‘Edit’ menu in the menu bar
>> 
>> But the documented ‘Text Properties’ menu is not displayed in enriched-mode.
>> 
>> This can be fixed by just requiring facemenu in enriched.el:
>
> Fine with me, please install.

So now installed and closed.