From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49261: Segfault during loadup Date: Thu, 15 Jul 2021 09:13:59 +0300 Message-ID: <83mtqo6r4o.fsf@gnu.org> References: <87o8bn7bie.fsf@gnus.org> <87zgv6vuon.fsf@gmx.de> <837di9lwbm.fsf@gnu.org> <87a6n5vuu4.fsf@gnus.org> <8735sqnmei.fsf@gnus.org> <87zguyf4ht.fsf@gmx.de> <87pmvum54p.fsf@gnus.org> <87v95mf2lj.fsf@gmx.de> <87pmvt3ob1.fsf@gnus.org> <83r1g9evoy.fsf@gnu.org> <83pmvtevgg.fsf@gnu.org> <87czrt3mj4.fsf@gnus.org> <878s2h3m1d.fsf@gnus.org> <874kd53lnl.fsf@gnus.org> <87zgux26ab.fsf@gnus.org> <87pmvt25uq.fsf@gnus.org> <87lf6h2294.fsf@gnus.org> <87h7h51x9y.fsf_-_@gnus.org> <83bl79b17n.fsf@gnu.org> <835yxgc1pm.fsf@gnu.org> <83wnpvag6z.fsf@gnu.org> <5608bf0a-7211-73a9-690f-c869a1cb3c9d@cs.ucla.edu> <83o8b7a5ow.fsf@gnu.org> <83eec1843o.fsf@gnu.org> <33801f54-3794-d98c-54c3-c67ce53ec6c0@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 49261@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 15 08:15:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3ueL-00008Q-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jul 2021 08:15:09 +0200 Original-Received: from localhost ([::1]:51346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3ueK-0000dr-FJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jul 2021 02:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3ueE-0000dg-Fq for bug-gnu-emacs@gnu.org; Thu, 15 Jul 2021 02:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3ueE-0001cg-7Y for bug-gnu-emacs@gnu.org; Thu, 15 Jul 2021 02:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3ueD-0004Zo-W6 for bug-gnu-emacs@gnu.org; Thu, 15 Jul 2021 02:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jul 2021 06:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49261 X-GNU-PR-Package: emacs Original-Received: via spool by 49261-submit@debbugs.gnu.org id=B49261.162632966417538 (code B ref 49261); Thu, 15 Jul 2021 06:15:01 +0000 Original-Received: (at 49261) by debbugs.gnu.org; 15 Jul 2021 06:14:24 +0000 Original-Received: from localhost ([127.0.0.1]:46494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3udc-0004Yn-JW for submit@debbugs.gnu.org; Thu, 15 Jul 2021 02:14:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3udZ-0004YZ-PS for 49261@debbugs.gnu.org; Thu, 15 Jul 2021 02:14:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38034) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3udT-0000zj-OH; Thu, 15 Jul 2021 02:14:15 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3udT-0007s0-Bt; Thu, 15 Jul 2021 02:14:15 -0400 In-Reply-To: <33801f54-3794-d98c-54c3-c67ce53ec6c0@cs.ucla.edu> (message from Paul Eggert on Wed, 14 Jul 2021 17:24:37 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209993 Archived-At: > Cc: larsi@gnus.org, 49261@debbugs.gnu.org > From: Paul Eggert > Date: Wed, 14 Jul 2021 17:24:37 -0500 > > I originally wrote it as "uintptr_t mask = VALMASK;" because I would > rather avoid C casts when possible (they're too powerful and allow too > many bugs to go undetected). I dislike the workaround that I installed > because of (a) its unnecessary cast and (b) the lack of clarity that > it's intended that we want to discard any bits outside UINTPTR_MAX ((b) > was a problem with my original code too). > > To try to fix both (a) and (b) I installed the attached further patch. > It is a bit more verbose than what C requires, but the verbosity should > help explain that masking with UINTPTR_MAX is intended, and the > verbosity shouldn't hurt efficiency. Thanks, I think this new code is much cleaner and less mysterious.