From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32736: bug#34715: bug#32736: 26; Bind `C-x 5 2' to `clone-frame' by default Date: Thu, 02 Sep 2021 15:03:58 +0300 Message-ID: <83mtovnpzl.fsf@gnu.org> References: <17bef02b-7dd4-4086-828f-59488a836ac1@default> <8735qofx6h.fsf@gnus.org> <83fsuoqx75.fsf@gnu.org> <87eea8e9u6.fsf@gnus.org> <83bl5cquu4.fsf@gnu.org> <87a6kwe7n9.fsf@gnus.org> <875yvke7kt.fsf@gnus.org> <87zgswcsdq.fsf@gnus.org> <835yvkqtc3.fsf@gnu.org> <87v93kcrbu.fsf@gnus.org> <834kb4qof0.fsf@gnu.org> <87k0jzbew7.fsf@gnus.org> <83wnnzo1op.fsf@gnu.org> <87fsun8kyw.fsf@gnus.org> <83v93jo0dl.fsf@gnu.org> <87mtov73t7.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12806"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 34715@debbugs.gnu.org, 32736@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 14:23:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLlkl-00035Y-RM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 14:23:35 +0200 Original-Received: from localhost ([::1]:59004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLlkj-00075a-UM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 08:23:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLlSo-0002MK-Nw for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 08:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLlSo-0000A6-EJ for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 08:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLlSo-0000LI-52 for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 08:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32736 X-GNU-PR-Package: emacs Original-Received: via spool by 32736-submit@debbugs.gnu.org id=B32736.16305842571252 (code B ref 32736); Thu, 02 Sep 2021 12:05:02 +0000 Original-Received: (at 32736) by debbugs.gnu.org; 2 Sep 2021 12:04:17 +0000 Original-Received: from localhost ([127.0.0.1]:39954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLlS1-0000K1-Do for submit@debbugs.gnu.org; Thu, 02 Sep 2021 08:04:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLlRv-0000Jf-Qq; Thu, 02 Sep 2021 08:04:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58100) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLlRq-0008Vz-ET; Thu, 02 Sep 2021 08:04:02 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLlRq-0000wj-5v; Thu, 02 Sep 2021 08:04:02 -0400 In-Reply-To: <87mtov73t7.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 02 Sep 2021 10:57:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213266 Archived-At: > From: Lars Ingebrigtsen > Cc: 34715@debbugs.gnu.org, 32736@debbugs.gnu.org > Date: Thu, 02 Sep 2021 10:57:24 +0200 > > >> > And the faces aren't copied, I think, they reference the same faces > >> > the original frame had. > >> > >> Right -- I don't really know how the face/frame stuff actually works. > >> If it was a very general problem, then surely we'd stumble across this > >> whenever we make a new frame. But the bug seems to manifest only on > >> terminal frames -- when we change the background mode. > > > > That's true, but it doesn't mean we don't have a deeper problem. > > True. I'll continue to debug this, but won't have time today, I > think... If you want to have a look meanwhile, please go ahead. :-) > It reproduces easily, and the bug seems to be caused by something called > by `frame-set-background-mode', but that may or may not be correct > (perhaps it's just doing something that triggers the real problem caused > somewhere else). I think I fixed this. The problem was indeed with letting the new frame manipulate a separate set of faces: we arrange for that in make-terminal-frame, but we were doing that a tad too late.