From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely Date: Wed, 08 Sep 2021 09:05:50 +0300 Message-ID: <83mtonob41.fsf@gnu.org> References: <87eea2cebb.fsf.ref@yahoo.com> <87eea2cebb.fsf@yahoo.com> <83eea2rn8z.fsf@gnu.org> <87h7exc2dk.fsf@yahoo.com> <83lf49r4bc.fsf@gnu.org> <87czplb51o.fsf@yahoo.com> <83ilzcpt0d.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26222"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, juri@linkov.net To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 08 08:06:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNqiq-0006df-R7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Sep 2021 08:06:12 +0200 Original-Received: from localhost ([::1]:41094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNqio-0007gU-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Sep 2021 02:06:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNqig-0007gK-Mf for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 02:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNqig-0005CS-8Q for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 02:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNqif-0000kh-R2 for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 02:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Sep 2021 06:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50424 X-GNU-PR-Package: emacs Original-Received: via spool by 50424-submit@debbugs.gnu.org id=B50424.16310811542877 (code B ref 50424); Wed, 08 Sep 2021 06:06:01 +0000 Original-Received: (at 50424) by debbugs.gnu.org; 8 Sep 2021 06:05:54 +0000 Original-Received: from localhost ([127.0.0.1]:58279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNqiY-0000kK-91 for submit@debbugs.gnu.org; Wed, 08 Sep 2021 02:05:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNqiT-0000k1-FJ for 50424@debbugs.gnu.org; Wed, 08 Sep 2021 02:05:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52232) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNqiN-0004xA-Ty; Wed, 08 Sep 2021 02:05:43 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2043 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNqiN-0005iy-Fe; Wed, 08 Sep 2021 02:05:43 -0400 In-Reply-To: (message from Alan Third on Wed, 8 Sep 2021 00:13:15 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213773 Archived-At: > Date: Wed, 8 Sep 2021 00:13:15 +0100 > From: Alan Third > Cc: Po Lu , Juri Linkov , > 50424@debbugs.gnu.org > > On Tue, Sep 07, 2021 at 01:41:38PM +0300, Eli Zaretskii wrote: > > > > I hope the information here will allow Juri and people who really > > understand the meaning of an image margin and relief (Alan?) fix the > > rest of the problem. > > AFAIK the margin and relief are entirely handled by the term code and > don't really have anything to do with the image itself. I expect > that's why this is an OS specific problem. The code to deal with that is identical in xterm.c and w32term.c. Can you perhaps help us understand the purpose and semantics of the delicate dance in the xdisp.c code I posted regarding images on the tool-bar buttons? AFAIU, the xterm/w32term code was written to reflect that, and the tab-bar code is simply a copy of the tool-bar code, except that the image spec is defined entirely in Lisp, instead of being dynamically redefined on the fly by the C code in the display engine. So we need to understand the meaning of the margins and the relief settings and their relation to the button being "selected" as well as to the value of auto-raise-tool-bar-buttons, in order to do in Lisp the same thing. Because xterm/w32term rely on this logic to clear the area when the mouse pointer moves off the button. > This actually looks slightly like a bug we have with normal images on > the NS port, where if an image is replaced with a slightly smaller one > part of the original image *may* not be cleared. I've never managed to > work out why it happens. It's similar, yes. But in the case in point the code which clears the area is working well for tool-bar buttons, and we don't change the image dimensions for the tab bar buttons. Thanks.