From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51658: [PATCH] Haiku port (again) Date: Tue, 09 Nov 2021 19:58:01 +0200 Message-ID: <83mtmd43fa.fsf@gnu.org> References: <87ee7surtv.fsf.ref@yahoo.com> <87ee7surtv.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51658@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 09 18:59:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkVOx-0002wG-HI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 18:59:19 +0100 Original-Received: from localhost ([::1]:55266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkVOw-00010h-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 12:59:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkVOh-0000zZ-In for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 12:59:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkVOf-0001wU-So for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 12:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkVOf-0007rq-Ry for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 12:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Nov 2021 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51658-submit@debbugs.gnu.org id=B51658.163648070030183 (code B ref 51658); Tue, 09 Nov 2021 17:59:01 +0000 Original-Received: (at 51658) by debbugs.gnu.org; 9 Nov 2021 17:58:20 +0000 Original-Received: from localhost ([127.0.0.1]:35701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkVO0-0007ql-BD for submit@debbugs.gnu.org; Tue, 09 Nov 2021 12:58:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkVNx-0007qS-6F for 51658@debbugs.gnu.org; Tue, 09 Nov 2021 12:58:18 -0500 Original-Received: from [2001:470:142:3::e] (port=50520 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkVNr-0001qv-QH; Tue, 09 Nov 2021 12:58:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DfAF03qMyduOwIQwaZvWNaDPZ19c8EOyl/hn7RhL7Nw=; b=mcsT+abfh0r/ QOVaajt059+noFaT4Fwll0ViXCTs81+glLCBgngpoox05QcZNkmzigL+XVdy7gSiALC4cfbWW9IMn EZCPs1flr5gg1PyPJJVYqkOzUxs2VErdO02zpW4HOzUe00AsQ+JwGVbMuF9kDPJmGOCO5cqMsbvO6 FJ0lQ0KnkK0bVqNF+RD587rZIDM3tVjSAGacnytCP1ezEyhVamqgoFYMvW9IU0dKv/c5r6uht0AQt dejEBcliE/ga1lI8CYpd8xI6Lt1j2+ooyGdHF5uUuZtUeq3uOcH74IsyPzTeEO3xxVZzuOZoGpf9C wwnCoJELanSMG4wtl18WPg==; Original-Received: from [87.69.77.57] (port=2658 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkVNo-0007lk-Rz; Tue, 09 Nov 2021 12:58:11 -0500 In-Reply-To: <87ee7surtv.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219469 Archived-At: > Date: Sun, 07 Nov 2021 19:29:32 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > OK, after using this port for more than a month now I can say it's > finally stable enough for heavy use. > > I think all the major bugs have been ironed out now, so I'm submitting > it for inclusion. > > I couldn't figure out how to turn multiple (hundereds) of git commits > into a single patch formatted like `git format-patch' would, so I > attached the output of `git diff' instead. > > Please take some time to review the code and possibly install it. Thanks. It's a large patch, so let's start with the general, a.k.a. "big" aspects. First, do we really need to use *.cc files and compile with a C++ compiler? Is that a necessity? AFAICT, the code in those *.cc files is plain C, so why not use a C compiler, as we do on every other platform? Next, the font backend stuff: do we really need 5 (five) backends? How about having just one: HarfBuzz+Cairo? That's the direction we go on other platforms, so how about making the Haiku code smaller and simpler and support just that single backend, and drop all the older ones? I'd definitely won't want to drag the unmaintained libm17n-flt into this port. If you are okay with the above, could you please update the patch, so that we could avoid reviewing code which eventually won't be installed?