From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Date: Fri, 14 Jan 2022 16:43:22 +0200 Message-ID: <83mtjy1iph.fsf@gnu.org> References: <509ddd0f-589c-45b0-9b60-5820f4c1d716@www.fastmail.com> <83sftr3nyx.fsf@gnu.org> <83h7a73fab.fsf@gnu.org> <87fspqz94l.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, ejb@ql.org, larsi@gnus.org, 53207@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 15:44:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8NoX-0007Yx-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 15:44:26 +0100 Original-Received: from localhost ([::1]:33856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8NoW-00019U-Rs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 09:44:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8NoA-00016D-QU for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 09:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8NoA-0000Sq-GC for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 09:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8NoA-0008PT-Bu for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 09:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53207 X-GNU-PR-Package: emacs Original-Received: via spool by 53207-submit@debbugs.gnu.org id=B53207.164217141432279 (code B ref 53207); Fri, 14 Jan 2022 14:44:02 +0000 Original-Received: (at 53207) by debbugs.gnu.org; 14 Jan 2022 14:43:34 +0000 Original-Received: from localhost ([127.0.0.1]:35991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Nni-0008OY-2z for submit@debbugs.gnu.org; Fri, 14 Jan 2022 09:43:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Nnd-0008OF-4C for 53207@debbugs.gnu.org; Fri, 14 Jan 2022 09:43:32 -0500 Original-Received: from [2001:470:142:3::e] (port=42128 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8NnX-0000IU-GD; Fri, 14 Jan 2022 09:43:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/Hm8lnSIDQc1hBoxYOtEm9+iQ99V48TIwoY/TwdNwH0=; b=ao1iBxNvKMZuq6wKf/it 2I1sX2OF1DCh2rBOEksueu00ukeONnP+P2ONT6pj7Mx+qVk+K/MRStE5dzsEEidCoY3RR8KYYhYcM Uamk5QTadGQIINhn0iyprkblrUXfC6zKO9EC1oKDroJqNsXk5lRj7eKKlkmaS4DsQnwidC2/RY74n L+S+JT+KNy9TzIFqc1+qEIiRi5nd9hnhvkKAeNXZF1dn4t29yJB+UWSHVLUH6DsO3tXrquAULyUvy TQQJNv0GqSJEq1FPbOJlu+yxL2SsVNj7oEcbb2Z1hqxHXA0449PAD2ySjHuHa2vPSX4AvBEYWA9mL CShuKuX7qOH2Nw==; Original-Received: from [87.69.77.57] (port=2635 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8NnX-0002yB-H1; Fri, 14 Jan 2022 09:43:23 -0500 In-Reply-To: <87fspqz94l.fsf@gmx.de> (message from Michael Albinus on Fri, 14 Jan 2022 15:26:18 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224209 Archived-At: > From: Michael Albinus > Cc: "Eli Zaretskii" , "Glenn Morris" , "Lars > Ingebrigtsen" , 53207@debbugs.gnu.org > Date: Fri, 14 Jan 2022 15:26:18 +0100 > > So it checks also the owner of the lock file. This makes only sense, if > create-lockfiles is non-nil; otherwise there is no lock file owner ... > > I agree with Eli, that the current behavior in Emacs 28 is > consistent. Since this is an incompatible change, we shall document > it. The Emacs 28 manual says > > --8<---------------cut here---------------start------------->8--- > You can prevent the creation of lock files by setting the variable > ‘create-lockfiles’ to ‘nil’. *Caution:* by doing so you will lose the > benefits that this feature provides. > --8<---------------cut here---------------end--------------->8--- > > Maybe it shall be more explicit saying, that also detection of changing > the modification time is lost when create-lockfiles is nil. We should say there that setting the variable to nil disables the entire editing collision detection, not just creation of the lock files. > etc/NEWS is silent about this, it should explain this subtle change as well. Right. Assuming we agree with the current behavior. Lars, WDYT?