From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59710: Wrong type argument when editing a multisession variable Date: Fri, 02 Dec 2022 15:07:02 +0200 Message-ID: <83mt86eyyx.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 59710@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 14:08:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p15mK-0003XM-Mk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 14:08:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p15lr-0001kQ-I6; Fri, 02 Dec 2022 08:08:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p15lq-0001k9-EL for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 08:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p15lq-0001Af-5C for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 08:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p15lq-0005EV-0H for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 08:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 13:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59710 X-GNU-PR-Package: emacs Original-Received: via spool by 59710-submit@debbugs.gnu.org id=B59710.166998645420108 (code B ref 59710); Fri, 02 Dec 2022 13:08:01 +0000 Original-Received: (at 59710) by debbugs.gnu.org; 2 Dec 2022 13:07:34 +0000 Original-Received: from localhost ([127.0.0.1]:46628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p15lN-0005EG-Fp for submit@debbugs.gnu.org; Fri, 02 Dec 2022 08:07:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p15lM-0005EA-A3 for 59710@debbugs.gnu.org; Fri, 02 Dec 2022 08:07:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p15lG-00015O-Vi; Fri, 02 Dec 2022 08:07:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l0ZShryvt9DzS1Lrpo+KR0J1YuHtztunTztIWbElOgY=; b=NkY9ufFiIdAw ecMHiV3jXwRizTc0KH5u2HL224CTUSGYf3A2Y70O2W2m2rB9nCZn/CjTC0OmH77VrTWNnMHKMBilP 4OKsze5FzgoF34ezFtZ74fNeNOHnd8c2ikSD9EtMAz6TSThdgObfGPBFONlxQThGUgJiTzFCm/v8C gS4tWEDhZvvgngUfjjiMIJ2bABOlUVVc1K3+7RcxAu9l+SyHMv5k/COMD3hUaWxHnmt0+NvutMC8g H96/OBeCTA+y90L74DEyPa9/DJzsxu0KImrbc+gw+a8c3TQ29xKkCXXPNYeyI3w6RYCBLhDI1SieE jgF3SETd/YpIrDhXAX4Imw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p15lG-0005TS-Cc; Fri, 02 Dec 2022 08:07:26 -0500 In-Reply-To: (message from Juanma Barranquero on Wed, 30 Nov 2022 02:49:15 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249740 Archived-At: > Cc: "lars ingebrigtsen" > From: Juanma Barranquero > Date: Wed, 30 Nov 2022 02:49:15 +0100 > > Debugger entered--Lisp error: (wrong-type-argument symbolp (intern (cdr id))) > multisession-edit-value(("test" . "test-var")) > funcall-interactively(multisession-edit-value ("test" . "test-var")) > command-execute(multisession-edit-value) > > The problem comes from this change > > commit bd586121ac21e046f60f75eeb0200866c38d6f9f > Author: Lars Ingebrigtsen > Date: 2022-01-22 11:56:13 +0100 > > Make the test for existing multisession variables more sensible > > * lisp/emacs-lisp/multisession.el (multisession-edit-value): > Unconfuse the code. > > diff --git a/lisp/emacs-lisp/multisession.el b/lisp/emacs-lisp/multisession.el > index 4a293796a8..25307594c6 100644 > --- a/lisp/emacs-lisp/multisession.el > +++ b/lisp/emacs-lisp/multisession.el > @@ -437,8 +437,8 @@ multisession-edit-value > (let* ((object (or > ;; If the multisession variable already exists, use > ;; it (so that we update it). > - (and (boundp (intern-soft (cdr id))) > - (symbol-value (intern (cdr id)))) > + (and (intern-soft (cdr id)) > + (bound-and-true-p (intern (cdr id)))) > ;; Create a new object. > (make-multisession > :package (car id) > > because `bound-and-true-p' is a macro that requires as argument a symbol, which (intern ...) is not. > > ELISP> (bound-and-true-p (intern "whatever")) > *** Eval error *** Wrong type argument: symbolp, (intern "whatever") > > so I'm afraid this change was never tested. > > The fix is reverting the change, doing perhaps this > > diff --git a/lisp/emacs-lisp/multisession.el b/lisp/emacs-lisp/multisession.el > index 9d6e8c0d88..78d4137317 100644 > --- a/lisp/emacs-lisp/multisession.el > +++ b/lisp/emacs-lisp/multisession.el > @@ -447,8 +447,9 @@ multisession-edit-value > (let* ((object (or > ;; If the multisession variable already exists, use > ;; it (so that we update it). > - (and (intern-soft (cdr id)) > - (bound-and-true-p (intern (cdr id)))) > + (if-let (sym (intern-soft (cdr id))) > + (and (boundp sym) (symbol-value sym)) > + nil) > ;; Create a new object. > (make-multisession > :package (car id) This makes sense to me, so please go ahead and install (assuming that the multisession tests still all pass after this change). Thanks.