From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60666: 30.0.50; [PATCH] Use field properties in Eshell buffers Date: Wed, 11 Jan 2023 14:15:29 +0200 Message-ID: <83mt6pmfmm.fsf@gnu.org> References: <83cz7nq588.fsf@gnu.org> <537ece85-8808-c7fa-71b0-c355ff3740bb@gmail.com> <83o7r6oadh.fsf@gnu.org> <6a94f805-cb0f-2328-71f8-c64891b18e06@gmail.com> <83o7r6m9os.fsf@gnu.org> <0535fb1d-9606-7324-2da3-4e86e0eb1610@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60666@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 11 13:16:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFa1z-0004rk-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Jan 2023 13:16:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFa1a-0003MJ-Di; Wed, 11 Jan 2023 07:16:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFa1X-0003LX-76 for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 07:16:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFa1R-00075Q-Oa for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 07:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFa1R-0002p0-Jn for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 07:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jan 2023 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60666-submit@debbugs.gnu.org id=B60666.167343931110752 (code B ref 60666); Wed, 11 Jan 2023 12:16:01 +0000 Original-Received: (at 60666) by debbugs.gnu.org; 11 Jan 2023 12:15:11 +0000 Original-Received: from localhost ([127.0.0.1]:41859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFa0c-0002nL-SC for submit@debbugs.gnu.org; Wed, 11 Jan 2023 07:15:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFa0X-0002mO-Bn for 60666@debbugs.gnu.org; Wed, 11 Jan 2023 07:15:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFa0R-0006bS-TA; Wed, 11 Jan 2023 07:14:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G4ry1/vTvcNfguerx4mfAnLj4Is3ZyT5K7B6W9iAFwo=; b=HJ5jTvM3XWxb mSsWm1smxquzrJWqd7rhhN5HqpleVERVGeyKPs3I5//y+gSsT4Fno1elr3Nm6g1u7kY+g/QWMdU9j y16g+RePR4SIxqFzZNkDMXJU7KOo7SSCF+AmRwLkC1ezJyRYV7/zoug166ug6e2MWCR7a4swaViQf aHC+b6UKTfCsOTU+XlcN1C6R9/SPj/8d1GkWegP0eje+Y935vBGZM5b0k/YHGxsDUMpBxXuCwNtbl RGcjW7C056TtuzRybhBrDL/qvmgAeEmmkHBFi7Z1G/LxOVyzjnoD8AoZS/eeOklkHQ63x3EPL6Fpi Kv5mHUo8SA/mqgj2w1k0Vw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFa0R-0007la-Cu; Wed, 11 Jan 2023 07:14:59 -0500 In-Reply-To: <0535fb1d-9606-7324-2da3-4e86e0eb1610@gmail.com> (message from Jim Porter on Tue, 10 Jan 2023 12:51:14 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253142 Archived-At: > Date: Tue, 10 Jan 2023 12:51:14 -0800 > Cc: 60666@debbugs.gnu.org > From: Jim Porter > > On 1/10/2023 12:11 PM, Eli Zaretskii wrote: > > That's not what I see in Emacs 29. C-a moves to the beginning of > > input, i.e. it stops at the end of the prompt, whereas HOME goes all > > the way to the beginning of screen line, including the prompt. > > > > "C-h c" says that C-a is bound to eshell-bol, but HOME is bound to > > move-beginning-of-line. > > > > I'm asking why not let users have this distinction after your change, > > with some easy customization? > > It sounds like we agree but we're looking at this from different > directions. Since my patch adds the 'field' property, a user can't just > use 'move-beginning-of-line' to go to the very beginning of the line > (instead, it stops at the end of the prompt, where the field property ends). > > I agree that an easy customization to restore the old behavior would be > nice. The old behavior has been around a long time, so I'm sure some > people have come to rely on it. > > One option would be to add a new function like 'eshell-really-bol' (with > a better name, of course), that calls 'move-beginning-of-line' and > ignores fields, like the function I suggested in the NEWS entry. This > function wouldn't be used anywhere by default, but it makes it easy for > users to restore the behavior. This is probably the simplest, most > direct way. I think 'eshell-really-bol' is the best alternative here, yes. Then NEWS could tell users to bind it to HOME or whatever. > Another option might be to enhance 'move-beginning-of-line'. Maybe we > could add an option so that calling it the first time obeys field > boundaries, but if you immediately call it again, it ignores them. Then, > a user who wants to go to the real beginning of a line can just press > (or C-a) twice. That's not exactly the same as the old behavior, > but it would be usable outside of Eshell, and it's pretty close to > maintaining muscle memory: you just need to press the same key again. Because this is not exactly the old behavior, I don't think it alone can be the response to backward-compatibility need. It could be a separate new feature, of course.