From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: juri@linkov.net, 60691@debbugs.gnu.org, monnier@iro.umontreal.ca,
dgutov@yandex.ru
Subject: bug#60691: 29.0.60; Slow tree-sitter font-lock in ruby-ts-mode
Date: Fri, 13 Jan 2023 13:51:15 +0200 [thread overview]
Message-ID: <83mt6mac0c.fsf@gnu.org> (raw)
In-Reply-To: <E6EC8A50-8CA9-40B5-B827-022FB7311D97@gmail.com> (message from Yuan Fu on Fri, 13 Jan 2023 01:15:09 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Fri, 13 Jan 2023 01:15:09 -0800
> Cc: Dmitry Gutov <dgutov@yandex.ru>,
> 60691@debbugs.gnu.org,
> Juri Linkov <juri@linkov.net>,
> Stefan Monnier <monnier@iro.umontreal.ca>
>
> > On Jan 12, 2023, at 11:57 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> Cc: 60691@debbugs.gnu.org, juri@linkov.net
> >> Date: Fri, 13 Jan 2023 01:40:56 +0200
> >> From: Dmitry Gutov <dgutov@yandex.ru>
> >>
> >> Managed to reproduce this after running the test in a couple of
> >> different files.
> >>
> >> But 'M-x memory-usage' says no such command, and 'M-x memory-report'
> >> ends up with this error:
> >>
> >> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
> >> memory-report--gc-elem(nil strings)
> >> memory-report--garbage-collect()
> >> memory-report()
> >
> > This means GC is disabled in this session at the time you invoke
> > memory-report. Which shouldn't happen, of course. It sounds like
> > your pure Lisp storage overflowed, and that disabled GC.
> >
> > And I think I see the problem: we use build_pure_c_string in treesit.c
> > in places that we shouldn't.
> >
> > Yuan, build_pure_c_string should only be used in places such as
> > syms_of_treesit, which are called just once, during dumping. Look at
> > all the other calls to this function in the sources, and you will see
> > it. In all other cases, you should do one of the following:
> >
> > . for strings whose text is fixed, define a variable, give it the
> > value in syms_of_treesit using build_pure_c_string, then use that
> > variable elsewhere in the source
>
> Can I define a bunch of static C variables and initialize them in syms_of_treesit, or they have to be all Lisp variables? Eg,
>
> static Lisp_Object TREESIT_STAR;
>
> ...
>
> void
> syms_of_treesit (void)
> {
> ...
> TREESIT_STAR = build_pure_c_string ("*");
> ...
> }
Yes, of course. Look, for example, how coding.c does that:
/* A string that serves as name of the reusable work buffer, and as base
name of temporary work buffers used for code-conversion operations. */
static Lisp_Object Vcode_conversion_workbuf_name;
[...]
void
syms_of_coding (void)
{
[...]
staticpro (&Vcode_conversion_workbuf_name);
Vcode_conversion_workbuf_name = build_pure_c_string (" *code-conversion-work*");
But please keep the convention of naming such variables Vsome_thing,
both regarding the "V" and the fact that the name is otherwise
lower-case.
Thanks.
next prev parent reply other threads:[~2023-01-13 11:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 17:16 bug#60691: 29.0.60; Slow tree-sitter font-lock in ruby-ts-mode Juri Linkov
2023-01-09 22:33 ` Dmitry Gutov
2023-01-10 8:10 ` Juri Linkov
2023-01-10 14:10 ` Dmitry Gutov
2023-01-10 17:50 ` Juri Linkov
2023-01-11 12:12 ` Dmitry Gutov
2023-01-11 12:12 ` Dmitry Gutov
2023-01-12 21:58 ` Yuan Fu
2023-01-12 23:40 ` Dmitry Gutov
2023-01-13 7:57 ` Eli Zaretskii
2023-01-13 9:15 ` Yuan Fu
2023-01-13 11:51 ` Eli Zaretskii [this message]
2023-01-14 3:48 ` Yuan Fu
2023-01-14 7:29 ` Eli Zaretskii
2023-01-14 7:51 ` Yuan Fu
2023-01-14 8:01 ` Eli Zaretskii
2023-01-14 8:46 ` Andreas Schwab
2023-01-14 23:03 ` Yuan Fu
2023-01-18 6:50 ` Yuan Fu
2023-01-19 18:28 ` Dmitry Gutov
2023-01-20 22:24 ` Yuan Fu
2023-01-22 2:01 ` Dmitry Gutov
2023-01-29 8:25 ` Yuan Fu
2023-01-29 23:07 ` Dmitry Gutov
2023-01-29 23:23 ` Yuan Fu
2023-01-30 0:15 ` Dmitry Gutov
2023-02-01 5:26 ` Yuan Fu
2023-02-01 15:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt6mac0c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60691@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).