From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER Date: Sat, 04 Mar 2023 17:04:25 +0200 Message-ID: <83mt4sa77q.fsf@gnu.org> References: <87ilfxv5dg.fsf@tcd.ie> <87h6vgelnn.fsf@tcd.ie> <83leksv6az.fsf@gnu.org> <87bkl972du.fsf@gmail.com> <83a60tarif.fsf@gnu.org> <87v8jg68l0.fsf@gmail.com> <83sfekadlg.fsf@gnu.org> <87jzzw646j.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35050"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 61637@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 16:05:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYTRh-0008sP-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 16:05:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYTRa-0005F0-SK; Sat, 04 Mar 2023 10:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYTRX-0005D5-Jb for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 10:05:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYTRW-000507-GT for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 10:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYTRW-000379-AJ for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 10:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61637-submit@debbugs.gnu.org id=B61637.167794228511945 (code B ref 61637); Sat, 04 Mar 2023 15:05:02 +0000 Original-Received: (at 61637) by debbugs.gnu.org; 4 Mar 2023 15:04:45 +0000 Original-Received: from localhost ([127.0.0.1]:37431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYTRF-00036b-8R for submit@debbugs.gnu.org; Sat, 04 Mar 2023 10:04:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYTRC-00036N-Ty for 61637@debbugs.gnu.org; Sat, 04 Mar 2023 10:04:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYTR7-0004xU-57; Sat, 04 Mar 2023 10:04:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rJ1p67b7s1FN1no6js9ZfK9KMMV6A6oXRfD3h2nqRnA=; b=LUtRbRvcZK2Q/gAZ9H/v 21dqKyofELVCyQMgpSIZpUI3zi2nLlbad4sqUTXmqiY1C2lNcJQSvHiOb9zgiTLvWDPN31yht78D2 FskljUzWdVOItZQwF3pbTq90mRzPVU/GWvzQBlhPn5JbHbmvg4cLNEe9NjeR95YA6fWJKaaJBYr/C nrVcbwMKnuLfxs+BCrlVzA9VHQ133siOc81HN8f/PiMb27eMKtezrpnOpwJSnHhMw483zoIQLzUln NSqqd7lXRyUm8gtqhYDLQhfoA/TC/WfwJAz7A1Q3qAHdJzyj9YmHjIvaJQwP46kGB7o0qDqUP0LRL yFLH8pOlQjbzpQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYTR6-00067K-Ce; Sat, 04 Mar 2023 10:04:36 -0500 In-Reply-To: <87jzzw646j.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 04 Mar 2023 13:23:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257283 Archived-At: > From: João Távora > Cc: contovob@tcd.ie, 61637@debbugs.gnu.org > Date: Sat, 04 Mar 2023 13:23:32 +0000 > > > You disregarded the second part of my reasoning, which has to do with > > the test results being non-deterministic once the user's real home > > directory is accessible to Emacs. How do we overcome that? > > Sorry I didn't mean to disregard, I just missed it. Well, it's not > accessible to Emacs, only to LSP servers. Eglot's tests are fairly are > deterministic, all other things like LSP server versions being equal. > > I'd say Eglot's tests are even robust to any changes in LSP server's > user init files. See how XDG_CONFIG_HOME is spooffed in eglot-tests.el > to this effect. It has been effective AFAICT for some time. And that's > only for those few servers that do offer these mechanisms: most of them > rely on project-local configurations which is fine because Eglot creates > a temporary project for each test. > > All in all, I think the problem of user file clobbering and determinism > are exaggerated -- in this specific case of course. They are secondary > to the fact that it's tricky, noisy, or even impossible to run Eglot > tests ever since Eglot moved to Emacs core. > > I propose we install my patch and then perfect the solution. Again, > we're only affecting those devs who _do_ have these local installations, > and that affection is much, much more likely to be beneficial than > harmful. OK, please go ahead, and thanks.